Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade jupyterlab to 3.3.x, add "sage -n nbclassic" and "sage -n retrolab" #32069

Closed
mkoeppe opened this issue Jun 27, 2021 · 68 comments
Closed

Upgrade jupyterlab to 3.3.x, add "sage -n nbclassic" and "sage -n retrolab" #32069

mkoeppe opened this issue Jun 27, 2021 · 68 comments
Labels
c: packages: optional p: major / 3 t: enhancement
Milestone
sage-9.6

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jun 27, 2021

#30246 added jupyterlab 2.2.x as an optional package as part of Meta-ticket #30399.

The 3.0 series has been out since December 2020. https://pypi.org/project/jupyterlab/#history

Current as of Mar 2022 is 3.3.0. It still supports Python 3.7, as needed for Sage 9.6.

It is now also possible to run the classic notebook on top of jupyterlab - https://pypi.org/project/nbclassic/
(See also https://github.com/jupyterlab/retrolab#relation-to-other-jupyter-frontends)

CC: @slel @jcamp0x2a @dimpase @egourgoulhon

Component: packages: optional

Keywords: jupyterlab

Author: Matthias Koeppe

Branch/Commit: 1243bd8

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/32069
@mkoeppe mkoeppe added this to the sage-9.4 milestone Jun 27, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 27, 2021

Dependencies: #31280

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 27, 2021

Changed dependencies from #31280 to #31280, #32071

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 27, 2021

Branch: u/mkoeppe/upgrade_jupyterlab_to_3_0_x

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 27, 2021

Last 10 new commits:

2694cbfbuild/pkgs/requests/checksums.ini: Add upstream_url
62769f9build/pkgs/rst2ipynb/checksums.ini: Add upstream_url
eb6d3d0build/pkgs/scandir/checksums.ini: Add upstream_url
e2cada9build/pkgs/snowballstemmer/checksums.ini: Add upstream_url
d83e2f8build/pkgs/wcwidth/checksums.ini: Add upstream_url
c943913build/pkgs/{backcall,ptyprocess}/dependencies: flit_core switched from pytoml to toml; remove pytoml package
6225684Merge #31280
0075b33build/pkgs/{scipy,sphinx,sympy}/install-requires.txt: Update version ranges to include the version in package-version.txt
5116399Merge #32071
62e5a88build/pkgs/jupyterlab: Update to 3.0.x

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 27, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 27, 2021

Commit: 62e5a88

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b348305Merge tag '9.4.beta4' into t/31280/jupyter_upgrade
2582707build/pkgs/ptyprocess: Revert upgrade to 0.7.0; pin version to 0.5.1
45cf013build/pkgs/rst2ipynb/patches: Remove
7762e01Merge #31280

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2021

Changed commit from 62e5a88 to 7762e01

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 6, 2021

Changed dependencies from #31280, #32071 to #31280

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 19, 2021

comment:8

Setting a new milestone for this ticket based on a cursory review.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@slel
Copy link
Member

slel commented Jul 27, 2021

comment:9

JupyterLab 3.1.0 was released.

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 12, 2021

Work Issues: merge updated #31280, update packages

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 14, 2021

Changed work issues from merge updated #31280, update packages to none

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 14, 2021

Changed dependencies from #31280 to #32493

@mkoeppe mkoeppe changed the title Upgrade jupyterlab to 3.0.x Upgrade jupyterlab to 3.1.x Sep 14, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0632776build/pkgs/jupyterlab: Update to 3.1.x
00f06a6build/pkgs/{bleach,html5lib,importlib_resources,sagenb_export}/dependencies: Add missing deps
ac8bce8Merge #31280
a15e3ebbuild/pkgs/{flit_core,jupyterlab_pygments,matplotlib_inline,nbclient,nbconvert}/dependencies: Add missing deps
dc094c0build/pkgs/{ipykernel,nbconvert}/dependencies: Add missing deps
c929321build/pkgs/nbclient/dependencies: fixup
41224afbuild/pkgs/nbconvert/dependencies: Add missing dep
0fc01d3build/pkgs/zipp: Update to 3.5.0
8a314c2build/pkgs/bleach/dependencies: Add six
7984ef6Merge #32493

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2021

Changed commit from 7762e01 to 7984ef6

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 14, 2021

New commits:

0632776build/pkgs/jupyterlab: Update to 3.1.x
00f06a6build/pkgs/{bleach,html5lib,importlib_resources,sagenb_export}/dependencies: Add missing deps
ac8bce8Merge #31280
a15e3ebbuild/pkgs/{flit_core,jupyterlab_pygments,matplotlib_inline,nbclient,nbconvert}/dependencies: Add missing deps
dc094c0build/pkgs/{ipykernel,nbconvert}/dependencies: Add missing deps
c929321build/pkgs/nbclient/dependencies: fixup
41224afbuild/pkgs/nbconvert/dependencies: Add missing dep
0fc01d3build/pkgs/zipp: Update to 3.5.0
8a314c2build/pkgs/bleach/dependencies: Add six
7984ef6Merge #32493

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 14, 2021

Changed dependencies from #32493 to #32493, #32482

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

59132abbuild/pkgs/tomli: New, dependency of setuptools_scm
7ebcb6cbuild/pkgs/setuptools_scm/dependencies: Add packaging
2def651build/pkgs/{packaging,pyparsing,setuptools_scm}/dependencies: Avoid circular deps
3e2fb34Merge #31280
aceeeebMerge #32493
bf15a7bbuild/pkgs/tomli/dependencies: Add flit_core
432699dbuild/pkgs/flit_core/dependencies: Remove dep on toml again, replace PYTHON_TOOLCHAIN by pip only, to break circular dep
f10ea0bbuild/pkgs/tomli/dependencies: Replace PYTHON_TOOLCHAIN by pip only, to break circular dep
4bdbdddbuild/pkgs/tomli/dependencies: Add toml because flit_core needs it at its runtime
1fc1ba3Merge #32482

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

1a3c7dfbuild/pkgs/{jupyter_packaging,ipympl}: Reduce to pip packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2022

Changed commit from efc92cd to 1a3c7df

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 5, 2022

comment:48

Thanks for testing! Here's a new version

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2022

Changed commit from 1a3c7df to 9b30976

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

9b30976build/pkgs/jupyterlab_widgets/package-version.txt: Remove

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2022

Changed commit from 9b30976 to 7b277c9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7b277c9build/pkgs/{jupyter_packaging,ipympl}: Reduce to pip packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2022

Changed commit from 7b277c9 to 9514d82

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9514d82build/pkgs/{jupyter_packaging,ipympl}: Reduce to pip packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1243bd8build/pkgs/{jupyter_packaging,ipympl}: Reduce to pip packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2022

Changed commit from 9514d82 to 1243bd8

@egourgoulhon
Copy link
Member

comment:55

Works like a charm now. Thank you!
I've also tested the new notebook interfaces nbclassic and retrolab. Thanks for having added them!

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@egourgoulhon
Copy link
Member

comment:56

The issue of %matplotlib widget being inoperative within the scope of %display latex is tracked in #33469. This is not specific to jupyterlab: it also happens with jupyter.

@egourgoulhon
Copy link
Member

Changed keywords from none to jupyterlab

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 6, 2022

comment:58

Thanks for testing!

@vbraun
Copy link
Member

vbraun commented Mar 9, 2022

Changed branch from u/mkoeppe/upgrade_jupyterlab_to_3_0_x to 1243bd8

@vbraun vbraun closed this as completed in 78990d5 Mar 9, 2022
@slel slel mentioned this issue Jan 7, 2023
Closed
This was referenced Jan 7, 2023
Closed
Open
Closed
@egourgoulhon egourgoulhon mentioned this issue Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
5 participants
@vbraun @egourgoulhon @dimpase @slel @mkoeppe