Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make jupyterlab a standard package, update notebook to 7.x #24904

Closed
slel opened this issue Mar 5, 2018 · 18 comments · Fixed by #36129
Closed

Make jupyterlab a standard package, update notebook to 7.x #24904

slel opened this issue Mar 5, 2018 · 18 comments · Fixed by #36129
Labels
c: user interface p: major / 3 t: enhancement
Milestone
sage-10.3

Comments

@slel
Copy link
Member

slel commented Mar 5, 2018

This ticket proposes to make JupyterLab a standard package.

This would require converting jupyterlab and jupyterlab_widgets from "pip" packages to "normal" packages (https://doc.sagemath.org/html/en/developer/packaging.html#package-source-types)
and adding their dependencies as "normal" packages as well.
#34450 allows us to use (non-platform) wheels instead of source packages, which simplifies things because we can avoid Javascript dependencies that are only needed at build time.

This is a mechanical task, which is assisted by https://doc.sagemath.org/html/en/developer/packaging.html#utility-script-to-create-packages but not fully automated (dependencies needs to be updated manually).

Discussion/vote:
https://groups.google.com/g/sage-devel/c/orUpb-YXIHk/m/GIxiKN4eDQAJ

Depends on #32069
Depends on #34450
Depends on #34454

CC: @slel @egourgoulhon @antonio-rojas

Component: notebook

Keywords: JupyterLab

Issue created by migration from https://trac.sagemath.org/ticket/24904
@slel slel added this to the sage-8.2 milestone Mar 5, 2018
@jdemeyer
Copy link

jdemeyer commented Mar 6, 2018

comment:1

There are two "rules" about standard packages:

  1. New standard packages should be optional first.

  2. There should be a discussion/vote on sage-devel for a new standard package.

Of course, exceptions are always possible for good reasons, but I see no such reason for jupyterlab.

@slel
Copy link
Member Author

slel commented Aug 15, 2018

comment:2

Dependency: #26059 Make JupyterLab an optional package.

@slel
Copy link
Member Author

slel commented Aug 15, 2018

Changed keywords from none to JupyterLab

@slel
Copy link
Member Author

slel commented Aug 15, 2018

Dependencies: #26059

@slel

This comment has been minimized.

Sign in to view
@slel
Copy link
Member Author

slel commented May 20, 2019

comment:3

Change milestone to sage-wishlist for a few tickets whose previous milestone is closed.

@slel slel removed this from the sage-8.2 milestone May 20, 2019
@slel

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe added this to the sage-9.3 milestone Aug 19, 2020
@mkoeppe
Copy link
Member

mkoeppe commented Aug 28, 2020

Changed dependencies from #26059 to #30246

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member

mkoeppe commented Feb 13, 2021

comment:7

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe
Copy link
Member

mkoeppe commented Jun 28, 2021

Changed dependencies from #30246 to #32069

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Make jupyterlab a standard package Make jupyterlab a standard package, replace notebook by nbclassic Jun 28, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member

mkoeppe commented Aug 29, 2022

Changed dependencies from #32069 to #32069, #34450

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 29, 2022
@mkoeppe
Copy link
Member

mkoeppe commented Aug 30, 2022

Changed dependencies from #32069, #34450 to #32069, #34450, #34454

@mkoeppe
Copy link
Member

mkoeppe commented Sep 29, 2022

comment:18

New roadmap from jupyterlab & notebook upstream: https://jupyter.org/enhancement-proposals/79-notebook-v7/notebook-v7.html#technical-details

@mkoeppe mkoeppe changed the title Make jupyterlab a standard package, replace notebook by nbclassic Make jupyterlab a standard package, update notebook to 7.x Sep 29, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@slel slel mentioned this issue Sep 11, 2020
Closed
@mkoeppe mkoeppe mentioned this issue Jan 7, 2023
Closed
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
@mkoeppe mkoeppe mentioned this issue Aug 24, 2023
Merged
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this issue Dec 4, 2023
sagemathgh-36129: Notebook 7, ipykernel 6.27, ipython 8.17
e922bd0 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

This is now based on JupyterLab. There are many changes in dependencies.

We are trying to use platform-independent wheels when available, to
avoid any Node.JS activity during our build.
Hence we remove our `nodeenv`, `nodejs`, `jupyter_packaging`,
`hatch_nodejs_version` packages.

There is trouble on the horizon regarding our model of building
everything from source: The latest versions of `jsonschema` have
switched from `pyrsistent` to a Rust-based package.
We use the newest versions that don't pull in the build dependency on
the Rust compiler.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Resolves sagemath#24904
- Resolves sagemath#30399
- Resolves sagemath#33772

<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#35251 (merged here)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36129
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Kwankyu Lee, Matthias Köppe, Michael Orlitzky
vbraun pushed a commit to vbraun/sage that referenced this issue Dec 5, 2023
sagemathgh-36129: Notebook 7, ipykernel 6.27, ipython 8.17
f336f6a 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

This is now based on JupyterLab. There are many changes in dependencies.

We are trying to use platform-independent wheels when available, to
avoid any Node.JS activity during our build.
Hence we remove our `nodeenv`, `nodejs`, `jupyter_packaging`,
`hatch_nodejs_version` packages.

There is trouble on the horizon regarding our model of building
everything from source: The latest versions of `jsonschema` have
switched from `pyrsistent` to a Rust-based package.
We use the newest versions that don't pull in the build dependency on
the Rust compiler.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Resolves sagemath#24904
- Resolves sagemath#30399
- Resolves sagemath#33772

<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#35251 (merged here)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36129
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Kwankyu Lee, Matthias Köppe, Michael Orlitzky
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 6, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: user interface p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging a pull request may close this issue.

Notebook 7, ipykernel 6.27, ipython 8.17 mkoeppe/sage
3 participants
@slel @jdemeyer @mkoeppe