Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crystals cannot be seen in the dark #35740

Closed
2 tasks done
mkoeppe opened this issue Jun 7, 2023 · 4 comments · Fixed by #36695
Closed
2 tasks done

Crystals cannot be seen in the dark #35740

mkoeppe opened this issue Jun 7, 2023 · 4 comments · Fixed by #36695
Labels
c: combinatorics c: documentation c: graphics t: bug
Milestone
sage-10.3

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jun 7, 2023

Is there an existing issue for this?

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.

Did you read the documentation and troubleshoot guide?

  • I have read the documentation and troubleshoot guide

Environment

web

Steps To Reproduce

  1. View https://doc.sagemath.org/html/en/thematic_tutorials/lie/crystals.html#crystals-of-letters
  2. Switch the doc theme to dark mode.

Expected Behavior

Crystals should glow in the dark.

Actual Behavior

Crystals cannot be seen.

Additional Information

@anneschilling @tscrim
@cherry-1729-9090
Copy link
Contributor

Hi. I have identified the issues as highlighted in the pictures. Could you please confirm whether the issues I identified are correct or not? If these are indeed the issues, I would like to work on resolving them. I have experience in Python, HTML, CSS, and Java and am eager to contribute to your projects.

Screenshot (26)
Screenshot (27)

@tscrim
Copy link
Collaborator

tscrim commented Nov 9, 2023

Yes, that is the issue. Feel free to work on it.

@cherry-1729-9090
Copy link
Contributor

Thank you for confirming! I'm excited to work on this. Since I'm new to your library, is there any documentation or specific guidelines I should refer to before opening a PR? Your guidance would be greatly appreciated.

@tscrim
Copy link
Collaborator

tscrim commented Nov 10, 2023

You can find all of the necessary information in our developer's guide: https://doc.sagemath.org/html/en/developer/

@cherry-1729-9090 cherry-1729-9090 mentioned this issue Nov 10, 2023
Merged
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this issue Dec 7, 2023
sagemathgh-36695: Dark Mode Compatibility: Improved Crystals Visibility
980b9be 
    
Fixes sagemath#35740

Format  `.png` images for dark mode compatibility

![image](https://github.com/sagemath/sage/assets/145871325/96a01567-
a701-476f-87cb-909f647425dc)


- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
    
URL: sagemath#36695
Reported by: cherry-1729-9090
Reviewer(s): Matthias Köppe
@vbraun vbraun closed this as completed in 5021c60 Dec 10, 2023
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics c: documentation c: graphics t: bug
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging a pull request may close this issue.

Dark Mode Compatibility: Improved Crystals Visibility cherry-1729-9090/sage
3 participants
@tscrim @mkoeppe @cherry-1729-9090