Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode Compatibility: Improved Crystals Visibility #36695

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

cherry-1729-9090
Copy link
Contributor

Fixes #35740

Format .png images for dark mode compatibility

image

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

Copy link

Documentation preview for this PR (built with commit 2748c2a; changes) is ready! 🎉

@mkoeppe
Copy link
Member

mkoeppe commented Nov 11, 2023

This works well, thanks very much.

@cherry-1729-9090
Copy link
Contributor Author

As the pull request is still pending, I would appreciate an update on its status. If there are any issues or feedback on my work, I am more than willing to address them promptly. Thank you for your time and assistance.

@mkoeppe

@mkoeppe
Copy link
Member

mkoeppe commented Nov 13, 2023

It will be merged at the beginning of the next release cycle; https://doc.sagemath.org/html/en/developer/review.html#the-release-process

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 7, 2023
    
Fixes sagemath#35740

Format  `.png` images for dark mode compatibility

![image](https://github.com/sagemath/sage/assets/145871325/96a01567-
a701-476f-87cb-909f647425dc)


- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
    
URL: sagemath#36695
Reported by: cherry-1729-9090
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 5021c60 into sagemath:develop Dec 10, 2023
18 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crystals cannot be seen in the dark
3 participants