Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.ci/create-changes-html.sh fails when an HTML file is removed #36887

Closed
2 tasks done
mkoeppe opened this issue Dec 15, 2023 · 3 comments · Fixed by #36888
Closed
2 tasks done

.ci/create-changes-html.sh fails when an HTML file is removed #36887

mkoeppe opened this issue Dec 15, 2023 · 3 comments · Fixed by #36888
Assignees
@kwankyu
Labels
t: bug
Milestone
sage-10.3

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Dec 15, 2023

Steps To Reproduce

https://github.com/sagemath/sage/actions/runs/7217053087/job/19664244861?pr=36885#step:11:156

Expected Behavior

diff created

Actual Behavior

+ PATH=/sage/venv/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin .ci/create-changes-html.sh 4725a0315a962bee6a612f04009dcb66c4e55b09 /sage/local/share/doc/sage/html
Traceback (most recent call last):
  File "<stdin>", line 12, in <module>
FileNotFoundError: [Errno 2] No such file or directory: '/sage/local/share/doc/sage/html/en/reference/spkg/deprecation.html'
cat: diff.html: No such file or directory
rm: cannot remove 'diff.html': No such file or directory

Additional Information

No response

Environment

CI

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide
@mkoeppe mkoeppe added the t: bug label Dec 15, 2023
@kwankyu
Copy link
Collaborator

kwankyu commented Dec 15, 2023

This seems the same symptom fixed by #36871

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 15, 2023

Ah, okay. I will investigate.

@kwankyu kwankyu mentioned this issue Dec 15, 2023
Merged
5 tasks
@kwankyu
Copy link
Collaborator

kwankyu commented Dec 15, 2023

Could you test the PR with the failing case?

vbraun pushed a commit to vbraun/sage that referenced this issue Dec 17, 2023
sagemathgh-36888: Fix failure of doc preview changes when an html is …
7ef39dd 
…removed

    
Fixes sagemath#36887.

Tested with sagemath#36892 and sagemath#36885.

<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

- sagemath#36871

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36888
Reported by: Kwankyu Lee
Reviewer(s):
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwankyu kwankyu

Labels
t: bug
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging a pull request may close this issue.

Fix failure of doc preview changes when an html is removed kwankyu/sage
2 participants
@kwankyu @mkoeppe