Decapitalize filenames of files in PREP doc #36892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kwankyu
force-pushed
the
p/decapitalize-prep-doc
branch
from
c29d08e
to
e2e0f8d
Compare
kwankyu
force-pushed
the
p/decapitalize-prep-doc
branch
4 times, most recently
from
fd716ef
to
c947d03
Compare
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 17, 2023
…removed
Fixes sagemath#36887.
Tested with sagemath#36892 and sagemath#36885.
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- sagemath#36871
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36888
Reported by: Kwankyu Lee
Reviewer(s):
kwankyu
force-pushed
the
p/decapitalize-prep-doc
branch
from
c947d03
to
97937a8
Compare
kwankyu
changed the title
|
Documentation preview for this PR (built with commit 97937a8; changes) is ready! 🎉 |
kwankyu
force-pushed
the
p/decapitalize-prep-doc
branch
from
97937a8
to
45c9baa
Compare
kwankyu
force-pushed
the
p/decapitalize-prep-doc
branch
2 times, most recently
from
7a81148
to
eaf8933
Compare
|
@mkoeppe I need some help. This PR works well locally. But here html doc build fails. This failure seems not genuine to me. Rather this seems to show certain failure of git or our workflow to properly deal with renamed files. Do you see how to overcome this? Thank you in advance. |
kwankyu
force-pushed
the
p/decapitalize-prep-doc
branch
from
eaf8933
to
44e71c1
Compare
Yes, I'm aware of this issue, it's also a big problem for the "CI Linux Incremental" runs. I hope to fix it this week. |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 8, 2024
…Uninstall/build changed packages; Linux Incremental: Update platforms
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes handling of deletions/renames
- https://groups.google.com/g/sage-devel/c/tw6J8vU7IY0/m/IZxuGW8gBQAJ
- sagemath#36892 (comment)
When changes to packages are made, "CI Build&Test" now uses the same
logic as "CI Linux Incremental" for determining what SPKGs to uninstall
(so that spkg-configure.m4 is re-run) and what optional SPKGs to
install.
We update the platforms of "CI Linux Incremental" and remove the default
platform from there, to remove the duplication with "CI Build&Test".
- Also apparently fixes sagemath#37786
For a test run with a PR that actually makes changes to packages, see
- sagemath#38147
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38144
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decapitalize filenames of files in
src/doc/en/prep/.To be consistent with other files in
src/.📝 Checklist
⌛ Dependencies