-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Build&Test: Replace use of sage -t --new
#37988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5 tasks
5 tasks
Documentation preview for this PR (built with commit abcb197; changes) is ready! 🎉 |
mkoeppe
force-pushed
the
ci_build_test_new
branch
2 times, most recently
from
May 16, 2024 16:56
c8cdbc4
to
8717183
Compare
5 tasks
mkoeppe
force-pushed
the
ci_build_test_new
branch
from
May 22, 2024 20:36
0223489
to
70fee8f
Compare
…ceeds, avoid rerunning bootstrap, configure
mkoeppe
force-pushed
the
ci_build_test_new
branch
from
May 25, 2024 17:58
70fee8f
to
eaccda6
Compare
kwankyu
reviewed
May 27, 2024
kwankyu
reviewed
May 27, 2024
kwankyu
reviewed
May 27, 2024
kwankyu
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. LGTM.
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 29, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#37985. We also turn on `--long --format github` for this run, so that annotations are shown in the "Files changed" tab. (Previously, only the annotations from the full testsuite run were shown, out of the concern of duplicating the numerous doctest style warnings. But these warnings have been much reduced, and the last two warnings are fixed in sagemath#38029.) Example run: https://github.com/sagemath/sage/actions/runs/9198070834/jo b/25299950120?pr=37988 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37926 (merged here) URL: sagemath#37988 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37985.
We also turn on
--long --format github
for this run, so that annotations are shown in the "Files changed" tab.(Previously, only the annotations from the full testsuite run were shown, out of the concern of duplicating the numerous doctest style warnings. But these warnings have been much reduced, and the last two warnings are fixed in #38029.)
Example run: https://github.com/sagemath/sage/actions/runs/9198070834/job/25299950120?pr=37988
📝 Checklist
⌛ Dependencies
Makefile
,.ci/write-dockerfile.sh
: Update forsrc/pyproject.toml
after #36982 #37926 (merged here)