-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile
, .ci/write-dockerfile.sh
: Update for src/pyproject.toml
after #36982
#37926
Conversation
Documentation preview for this PR (built with commit 4c076bb; changes) is ready! 🎉 |
.ci/write-dockerfile.sh
: Update for src/pyproject.toml
after #36982Makefile
, .ci/write-dockerfile.sh
: Update for src/pyproject.toml
after #36982
…#36982 Signed-off-by: ci-sage workflow applying sagemath#37926 @ https://github.com/sagemath/sage/commits/f52bf519387ccb963a38560bbbd97479da723c91 <ci-sage@example.com>
Signed-off-by: ci-sage workflow applying sagemath#37926 @ https://github.com/sagemath/sage/commits/f52bf519387ccb963a38560bbbd97479da723c91 <ci-sage@example.com>
Signed-off-by: ci-sage workflow applying sagemath#37926 @ https://github.com/sagemath/sage/commits/f52bf519387ccb963a38560bbbd97479da723c91 <ci-sage@example.com>
… src Signed-off-by: ci-sage workflow applying sagemath#37926 @ https://github.com/sagemath/sage/commits/f52bf519387ccb963a38560bbbd97479da723c91 <ci-sage@example.com>
hmm, tagging doctests as "known bugs" does not look like a good permanent solution |
That's right, this is a bad temporary solution. This is fallout from the big revert in #37796. |
I've removed the commits that made changes to |
76de186
to
2393541
Compare
…ker Desktop client
…t been copied in fully
… the default from_docker_tag in docker.yml
… retrofit-worktree.sh
This PR is mostly about CI maintenance, pertaining to the proposal: https://groups.google.com/g/sage-devel/c/dEa3i2Fn3ZY As such, I apply "show" model for reviewing this PR (that is, believe the maintainer is doing the right things). |
Thanks! |
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#37985. We also turn on `--long --format github` for this run, so that annotations are shown in the "Files changed" tab. (Previously, only the annotations from the full testsuite run were shown, out of the concern of duplicating the numerous doctest style warnings. But these warnings have been much reduced, and the last two warnings are fixed in sagemath#38029.) Example run: https://github.com/sagemath/sage/actions/runs/9198070834/jo b/25299950120?pr=37988 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37926 (merged here) URL: sagemath#37988 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#37985. We also turn on `--long --format github` for this run, so that annotations are shown in the "Files changed" tab. (Previously, only the annotations from the full testsuite run were shown, out of the concern of duplicating the numerous doctest style warnings. But these warnings have been much reduced, and the last two warnings are fixed in sagemath#38029.) Example run: https://github.com/sagemath/sage/actions/runs/9198070834/jo b/25299950120?pr=37988 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37926 (merged here) URL: sagemath#37988 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
Also some unrelated fixes:
centos-7-devtoolset
needed to adjust for a small change in how Docker files are parsed (https://github.com/sagemath/sage/actions/runs/8931531493/job/24538795775).ubuntu-xenial-...
and other platforms that need specialconfigure
args📝 Checklist
⌛ Dependencies