Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile, .ci/write-dockerfile.sh: Update for src/pyproject.toml after #36982 #37926

Merged
merged 14 commits into from
May 25, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 3, 2024

Also some unrelated fixes:

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this May 3, 2024
@mkoeppe mkoeppe added p: blocker / 1 p: CI Fix merged before running CI tests c: scripts labels May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Documentation preview for this PR (built with commit 4c076bb; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe changed the title .ci/write-dockerfile.sh: Update for src/pyproject.toml after #36982 Makefile, .ci/write-dockerfile.sh: Update for src/pyproject.toml after #36982 May 3, 2024
mkoeppe added a commit to mkoeppe/sage that referenced this pull request May 6, 2024
mkoeppe added a commit to mkoeppe/sage that referenced this pull request May 6, 2024
mkoeppe added a commit to mkoeppe/sage that referenced this pull request May 6, 2024
mkoeppe added a commit to mkoeppe/sage that referenced this pull request May 6, 2024
@fchapoton
Copy link
Contributor

hmm, tagging doctests as "known bugs" does not look like a good permanent solution

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 8, 2024

That's right, this is a bad temporary solution.

This is fallout from the big revert in #37796.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 8, 2024

I've removed the commits that made changes to .github/workflows/*macos.yml to reduce the scope of the PR; these commits are now on #37919.

@mkoeppe mkoeppe force-pushed the fix_ci_linux branch 4 times, most recently from 76de186 to 2393541 Compare May 10, 2024 08:13
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 14, 2024
@kwankyu
Copy link
Collaborator

kwankyu commented May 22, 2024

This PR is mostly about CI maintenance, pertaining to the proposal: https://groups.google.com/g/sage-devel/c/dEa3i2Fn3ZY

As such, I apply "show" model for reviewing this PR (that is, believe the maintainer is doing the right things).

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 22, 2024

Thanks!

@vbraun vbraun merged commit 0da8273 into sagemath:develop May 25, 2024
16 of 19 checks passed
vbraun pushed a commit to vbraun/sage that referenced this pull request May 29, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes sagemath#37985.

We also turn on  `--long --format github` for this run, so that
annotations are shown in the "Files changed" tab.
(Previously, only the annotations from the full testsuite run were
shown, out of the concern of duplicating the numerous doctest style
warnings. But these warnings have been much reduced, and the last two
warnings are fixed in sagemath#38029.)

Example run: https://github.com/sagemath/sage/actions/runs/9198070834/jo
b/25299950120?pr=37988

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37926 (merged here)
    
URL: sagemath#37988
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request May 31, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes sagemath#37985.

We also turn on  `--long --format github` for this run, so that
annotations are shown in the "Files changed" tab.
(Previously, only the annotations from the full testsuite run were
shown, out of the concern of duplicating the numerous doctest style
warnings. But these warnings have been much reduced, and the last two
warnings are fixed in sagemath#38029.)

Example run: https://github.com/sagemath/sage/actions/runs/9198070834/jo
b/25299950120?pr=37988

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37926 (merged here)
    
URL: sagemath#37988
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants