Remove Guava from standard Sage

[sagetrac-mabshoff]

We currently ship Guava per default in the GAP.spkg. But Guava is limited in functionality, i.e. compared to Magma see http://wiki.sagemath.org/magma#CodingTheory for a list by wdj, and tends to crash at exit, too.

The following doctests fail when guava is removed from the GAP spkg.

sage -t -long "devel/sage/sage/combinat/combinat.py"
sage -t -long "devel/sage/sage/combinat/designs/block_design.py"
sage -t -long "devel/sage/sage/coding/linear_code.py"
sage -t -long "devel/sage/sage/coding/code_bounds.py"
sage -t -long "devel/sage/sage/coding/code_constructions.py"
sage -t -long "devel/sage/sage/coding/guava.py"

Cheers,

Michael

CC: @wdjoyner

Component: packages: standard

Author: David Joyner

Reviewer: Robert Miller

Merged: 4.0.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/5701

[wdjoyner]

Attachment: trac_5701-guava-extraction.patch.gz

based on 4.0.a0

[rlmill]

comment:1

Attachment: trac_5701-ref-suggestions.patch.gz

I have run tests and checked the code here, and everything seems fine, with the following caveat: I did not run tests on a fresh install, i.e. I ran tests on a system with Guava still installed.

I will give this a positive review, pending the tests passing on a system with the right GAP spkg and workspace setup, and wdj will follow up on #6094.

[wdjoyner]

Attachment: trac_5701-guava-extraction2.patch.gz

to be applied after the other 2 patches (all three can be based on 4.0.rc0)

[wdjoyner]

comment:2

I just added a third patch. If you remove guava from gap*/pkg, reset the GAP workspace, and then apply these three patches then all tests pass on a 64bit ubuntu 9.04 machine.

[rlmill]

comment:3

Since you are adding an input to wtdist_gap, you also need to add a description to the INPUT section.

[wdjoyner]

Attachment: trac_5701-ref-suggestions2.patch.gz

to be applied after the others.

[wdjoyner]

comment:4

Adds 2 line description to linear_code.py docstring following referees suggestion.

[ncalexan]

Author: David Joyner

[ncalexan]

Merged: 4.0.2.alpha1

[ncalexan]

Reviewer: Robert Miller

[ncalexan]

Changed merged from 4.0.2.alpha1 to 4.0.2.alpha0