-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change all occurrences of "method" to "algorithm" #6094
Comments
comment:1
"method" is not only easier to say, but it's easier to spell, and probably is more memorable to people... |
comment:2
Replying to @jasongrout:
It is also not the standard arg name. If you think method is better, take it to the mailing list. |
comment:3
okay, I didn't realize there was a standard. The weight of history changes the situation a bit. |
comment:4
Replying to @jasongrout:
Actually, neither did I. But when David and I did a search for "method=", most of what we found were places where he was using that name. In fact, here is a complete (I think) list of the functions which use this (4.0.alpha0):
|
comment:5
Thanks. I'll get to these when #5701 is applied unless someone says I should just create a patch based on the patches there. |
based on 4.0.rc0 and all patches in #5701 |
comment:6
Attachment: trac_6094-method-vs-algorithm.patch.gz The current patch passes sage -testall with guava removed and all patched on #5701 applied. |
comment:8
Fails to apply cleanly to Sage 4.0.1.
|
comment:9
I don't know how to rebase. Can someone point me to a reference? I might be able to do it this weekend. |
Attachment: trac_6094-rebased_against_4.3.1.rc0.patch.gz I rebased this against 4.3.1.rc0. |
Reviewer: Rob Beezer |
comment:11
Passes all tests. There are more instances of the use of |
Author: David Joyner, William Stein |
comment:13
It was pointed out by people in our status reports session that this patch violates our deprecation policy. Yuck. I.e., technically we should do
basically everywhere, then remove them all in a year. Hmmmm.... |
comment:14
I've sent this back to "needs work" to await deprecation warnings. With more to do, include the changes in ccoding/code_bounds.py here as part of this ticket (see #7971). |
comment:15
I wonder if it could be done with a decorator?
|
comment:26
By the way, this patch contains all changes which were at one point suggested to be contained in Trac #7971. That trac can therefore be closed/invalidated. |
Changed reviewer from Rob Beezer to Rob Beezer, Robert Miller |
Work Issues: rebase |
comment:28
The patch needs to be rebased to sage-4.6.1.alpha0:
|
comment:29
Attachment: trac_6094-4.6.1.alpha0.with_deprecation.patch.gz |
comment:30
Robert Miller already gave the green light to the old version, so the review is only for the minor change in sage.matrix.matrix_double_dense made for rebasing. |
Changed work issues from rebase to none |
Merged: sage-4.6.1.alpha3 |
Changed author from David Joyner, William Stein, Johan S. R. Nielsen to David Joyner, William Stein, Johan Sebastian Rosenkilde Nielsen |
In a discussion with David, we realized that he's been using "method" for "algorithm" in several places. This fix will follow up on #5701, and will probably depend on the patches there.
CC: @wdjoyner
Component: coding theory
Author: David Joyner, William Stein, Johan Sebastian Rosenkilde Nielsen
Reviewer: Rob Beezer, Robert Miller
Merged: sage-4.6.1.alpha3
Issue created by migration from https://trac.sagemath.org/ticket/6094
The text was updated successfully, but these errors were encountered: