Use modal dialogs instead of javascript prompts for the rename prompt.

[TimDumol]

Javascript prompts are jarring, and more importantly, are not properly handled by Selenium.

CC: @williamstein @qed777

Component: notebook

Author: Tim Dumol

Reviewer: Mitesh Patel

Issue created by migration from https://trac.sagemath.org/ticket/7310

[TimDumol]

Attachment: trac_7310-modals.patch.gz

Replaces the javascript prompt with a modal dialog. Light dependency on #7309

[TimDumol]

Author: Tim Dumol

[TimDumol]

comment:1

This patch relies on an additional body id introduced in #7309, but can easily be rebased if #7309 is not accepted.

[TimDumol]

Attachment: trac_7310-modals.2.patch.gz

Adds a 100ms fade in effect and prevents a warning under strict warnings mode (trailing comma).

[TimDumol]

Makes the rename dialog appear only when the page is fully loaded.

[qed777]

comment:2

Attachment: trac_7310-modals.3.patch.gz

I tried v3, but the rename dialog was improperly rendered, possibly because an icon is missing? But why not use jQuery UI dialog, since we're already loading the library and it has built-in theme support?

I don't mean to pile on --- I'm happy to go through the Sage templates and code, converting alerts and prompts to dialogs.

[TimDumol]

Attachment: trac_7310-modals.4.patch.gz

Adds a new function modal_prompt(...) to replace prompt() dialogs based on jQuery UI Dialog.

[TimDumol]

comment:3

This should do the job. acking spotted only those two prompts. Alerts should probably be dealt in another ticket, if at all. This may be useful, if you're interested: http://boedesign.com/blog/2009/07/11/growl-for-jquery-gritter/.

[qed777]

comment:4

I'll try to take a closer look tomorrow. A quick note: The bgiframe plugin is already in sagenb/data/jqueryui/development-bundle/external.