New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert ECL back to ecl-10.2.1 and apply patches for Solaris 10 and OpenSolaris x64 #9474
Comments
Reverts ECL back to an older version, while preseving a couple of important Solaris and OpenSolaris patches |
comment:1
Attachment: 9474.patch.gz I think |
comment:2
Replying to @nexttime:
Yes, give me a few minutes and I'll update it. |
Attachment: 9474.2.patch.gz Correction SunOs -> SunOS |
Author: David Kirkby |
comment:3
There's a package for review at http://boxen.math.washington.edu/home/kirkby/patches/ecl-10.2.1.p0.spkg Dave |
comment:4
Looks at least reasonable, and doesn't break things on other platforms. I cannot really judge (or test) the behavior on SunOS/Solaris, though, especially regarding the test for |
comment:5
Btw, if [ "$VAR" = word ] ; then
... is sufficient, you don't need an extra character there, nor does -Leif |
comment:7
Replying to @nexttime:
It's less portable without the extra character! (You might note that autoconf adds the extra character too). I just get into a habit of writing my code the most portable way, even if in this case it will be run with bash, which for all recent versions at least does not require an extra character. I'm aware that there are no quotes needed - you might not the new code which deletes the temporary files has no such quotes. Dave |
comment:8
Replying to @nexttime:
I appreciate that. But all 3 options are POSIX, and as you say it does not break on any other platform. Basically that test ensures the code will only be executed on a very specific platform where I know there is an issue. Here's the output on my Sony Vaio laptop (OpenSolaris 2009.06 snv_111b)
on disk.math.washington.edu (OpenSolaris 2008.11 snv_101b_rc2)
and my Sun Ultra 27 (OpenSolaris 2009.06, upgraded to snv_134)
Note I did not use the unportable '-p' option. That does not work on HP-UX. So can this get a positive review? Dave |
comment:9
Can you or someone test this on a few non-Solaris systems before the positive review? |
comment:11
Replying to @sagetrac-drkirkby:
I had only the specific version number (and to some extent "i86pc") in mind, not the options to |
comment:12
Replying to @nexttime:
All systems I know of report the same. It may be the problem exists on some other variations of Solaris (OpenSolaris on SPARC, Solaris 10 on x86, Solaris 10 on 64-bit SPARC), but I don't know that. Hence it is restricted to only the systems where I know its a problem. Dave |
comment:13
Replying to @rlmill:
== Testing on sage.math (a Sun running Ubuntu Linux 8.04.4 LTS. ) ==
This is the same failure William got with the sage-4.5.alpha4, and is a result of a lack of memory:
I don't know how much memory that tests needs, but its passed for me before. Perhaps it needs more RAM than other tests. I'll test on OS X (bsd.math) too, but note the changes are Solaris specific, so Linux and OX X should see exactly the same code. Dave |
comment:14
I successfully installed the spkg linked here onto a build of 4.5.rc0, and am now testing the sage library. I ignored the two patches on this ticket since they appear to be changes to an spkg. If this is wrong (i.e. if I need to do something with the two patches before testing) please tell me. This is on an AMD Opteron running ubuntu linux. |
comment:15
Replying to @JohnCremona:
Thank you.
That is not wrong. The patches are already in the .spkg, so you do not need to apply.
Dave |
comment:16
OK then, I can now report that testing the whole Sage library worked fine after installing the new spkg. |
comment:17
The new spkg (actually this one plus the patch at #9187) installs for me on OS X 10.6 when building spkgs in parallel. I haven't gotten to the doctesting part of things, but if there are problems, I'll report them here. |
comment:18
All doctests pass for me on OS X 10.6. The new spkg also has built successfully on t2.math, and I'm running doctests now. |
comment:19
Replying to @jhpalmieri:
I looked in John's directory
Those two failures need to be resolved. I created tickets (#9489 and #9490) for these two doctest failures. The longest test was:
so it looks like one needs a SAGE_TIMEOUT_LONG >= 3600 seconds (one hour) to be reasonably confident of not getting a timeout on 't2.math'. Dave |
comment:20
John's successful tests would appear to have been built with
My successful tests on OS X were also using ecl-10.2.1.p1.spkg from #9187. Dave |
comment:21
Replying to @sagetrac-drkirkby:
Yes, that's right. That's what I meant in my comment above. I'm marking this as "positive review" since it builds on sage.math, OS X, and t2 without problem. By the way, Dave, my build on t2 only took 2 hours this time (!) -- this is without ATLAS and the docs, of course. Some of the speedup is probably because of building in /scratch instead of /home, so thanks for that pointer. |
Reviewer: John Palmieri |
This comment has been minimized.
This comment has been minimized.
comment:22
Merged, but as part of #9187. |
Merged: sage-4.5.rc1 |
Since it is claimed ECL and Maxima are causing doctest failures on sage.math (see #9460) a decision has been made to revert ECL and Maxima. This patch will use the old version, but with a couple of patches which are already positively reviewed to allow ECL to build on Solaris 10 and OpenSolaris x64.
Let's hope this solves the problem, as several people manage to build sage-4.5.alpah4 on sage.math.washington.edu with Maxima tests passing, and other tests have failed on sage.math too.
Dave
To the release manager: merge the spkg from #9187 instead.
Component: porting: Solaris
Author: David Kirkby
Reviewer: John Palmieri
Merged: sage-4.5.rc1
Issue created by migration from https://trac.sagemath.org/ticket/9474
The text was updated successfully, but these errors were encountered: