New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random Tree constructor for graphs section #9676
Comments
comment:1
Hellooooo !! Well, a long list of comments, which is perfectly normal for a first patch :-)
should become
It does not need to be complicatd, most of the time. It is just a way for Sage to check it "seems" fine, so that we notice something has gone wrong is we modify the method is_tree or anything related. And I am sure there is something else I had to say but forgot it O_o Well, if you have any question, I'll be behind my emails Nathann |
comment:2
Dear all, |
comment:3
The patch I uploaded yesterday was incorrectly built. I believe this one should be OK. |
comment:4
Helloooooo !!! Well, I hold nothing against this new version... I did not know about this encoding for trees, and I am glad I learned about it I still have several remarks... From top to bottom :
Ok, some explanations may be needed with the docstrings. In any Sage method you will see a lot of examples, like the ones you just wrote yourself. It is nice for the users, who have an idea how to use the methods, and it is also tested automatically. A new version of Sage is NOT released if ALL the tests do not pass. This way, if some mistake in a part of Sage's code creates a problem 10 methods further, we can locate it. And here is how it works : You have been copying a list of commands, and the result they give. When running tests on only one file, in your case by
The actual code, now. Mostly asthetics:
Well, this was a long list again. Many of my remarks being just aesthetic, disregard those if you do not like them. And please forgive me Generally, a method can not be accepted if all the doctests do not pass. So ensure that I expect the next one version will be the last Nathann |
comment:5
Now passes all tests. |
comment:6
Hello Edward !! Well, as you told me you were busy these times, and I am on vacation waiting for a plane.... If you like these modifications, you can set my patch (and so this whole tiket, as I reviewed yours) as positively reviewed Thank you for your additions ! I'll try to take care of your other patches now. Nathann |
Cosmetics on top of Edward's patch |
comment:7
Attachment: trac_9676-cosmetics.patch.gz Hi Nathann, I tested the new code and am satisfied with the results. I think this is fine to incorporate into the next Sage release. Thanks for the help!!! -Ed |
comment:8
Yet another graph patch ! Yeahhhhhhhhhhhhhhhhhhhh !!! Nathann |
comment:9
Could someone prepend the ticket number to the commit string for attachment: trac_9676.patch (and restore the status to "positive review")? Also, please update the "Author(s)" and/or "Reviewer(s)" fields. |
New, improved, repaired RandomTree graph constructor |
comment:10
Attachment: trac_9676.patch.gz Commit string edited as requested. |
Reviewer: Nathann Cohen |
Merged: sage-4.6.alpha1 |
This adds a RandomTree constructor to the graphs class. Users can type g=graphs.RandomTree(n) to create a new random tree with n vertices named 0 through n-1.
Component: graph theory
Author: Ed Scheinerman
Reviewer: Nathann Cohen
Merged: sage-4.6.alpha1
Issue created by migration from https://trac.sagemath.org/ticket/9676
The text was updated successfully, but these errors were encountered: