Upgrade python to 2.7.x #9958
Comments
|
comment:1
First attempt is at: John (jhpalmieri) reports that this builds but Sage does not on sage.math, and "packages for Apparently the fix for http://bugs.python.org/issue7491 causes some of these problems. On the numpy/scipy lists Ralf Gommers says "Numpy 1.5 should work with Python 2.7 and 3.1 and not be too far off. In August hopefully". So it looks like #9808 should fix the numpy issues. |
|
comment:5
Replying to @sagetrac-mhampton:
This fix has been included in python-2.6.5 onwards. We are using 2.6.5 which includes this fix and everything builds (haven't tried 2.7 yet). The only problem we have is with http://github.com/cschwan/sage-on-gentoo/issues#issue/1 so I think it is unfair to single out this issue as the source of problems. |
|
comment:6
Is there still any interest in this upgrade? I wanted to use ordered dictionaries, which require 2.7. Unfortunately, active participation in this ticket is beyond my current capabilities... |
|
comment:7
It will happen at least in sage-on-gentoo as we are following the system python. We are not talking about using the new capabilities just porting, I imagine my |
|
comment:8
I just attached a patch that is needed for python 2.6.5 and later. |
|
comment:10
Build sage-4.6.2 (and dependency) against python-2.7.1 on OS X. I get a lot of the following I patched python with the cpickle patch. Any ideas? |
|
comment:11
A lot of "doctest... DeprecationWarning: ..." lines that were expected are just gone. Which fails the test. |
|
comment:12
Lots of numerical and a little bit of formatting noise. |
|
comment:13
Ok so now I understand the differences between unittest and unittest2 which is shipped with python-2.7. This will require a massive number of non-backward compatible changes. I am starting to experiment with a few sage components but that promise to be long and boring. |
|
comment:15
I have attached a log of sage -testall. This is a sage-on-gentoo install a few tests are expected to fail https://github.com/cschwan/sage-on-gentoo/wiki/Known-test-failures but it should give you an idea of the problems we face. |
This comment has been minimized.
This comment has been minimized.
|
comment:17
I attached a log of test failures with 4.7.alpha4 (+ #7377). It is mostly number of decimals and messages. I added PYTHONWARNINGS=default to sage-env so I collected extra messages. The most important one being the deprecations of "sets". There are 3 tests killed reason currently unknown. And a few that may need special attention. |
|
comment:18
A little bit more details, these are curious: This one doesn't worry me as much but should be looked at The following were killed: In my original run also got killed but not in a subsequent run after I adopted a small change in sage-doctest to get rid of PYTHONWARNINGS=default in sage-env. Example of killed test: |
|
small patch to sage-doctest in sage_script to reenable sage's deprecation warnings. Idea by my friend Steve Trogdon. |
|
Attachment: trac_9958-reenable-sage-deprecationwarnings.patch.gz Attachment: trac_9958-fix_cmp.patch.gz this form of comparison is removed in python 2.6.5 and later, refreshed using --git. |
|
comment:19
It looks like the crash problems originates somewhere in libsingular |
|
comment:20
Same two doctests killed after upgrade to alpha5. |
|
comment:21
Over-eager garbage collection in python-2.7.1! Preceding the sequence by Makes everything go smoothly. |
This comment has been minimized.
This comment has been minimized.
|
comment:23
trac_9958-fix_cmp.patch is perfectly reasonable, since this is the idiom used everywhere else in similar situations. I don't have enough background to judge on the warning patch. |
|
comment:24
Put an updated list of tests failing with 4.7.alpha5 and the latest patches from Nicolas M. Thiery. |
|
comment:25
Split the deprecation issue in its own ticket in #11244 - this is a different patch. |
This comment has been minimized.
This comment has been minimized.
|
comment:26
Replying to @nthiery:
I will put the cmp patch in its own ticket would you review it? |
|
comment:276
attachment: 9958_combinat.patch is the only non-trivial change I guess, but has been discussed well in the comments on this ticket. Potentially, the |
|
comment:277
Replying to @jdemeyer:
I didn't notice you had listed this particular patch. Why not use attachment: trac_9958-suffix_trees-variations-sl.patch from Sébastien Labbé instead? It is more foolproof. |
|
comment:278
I obviously meant to use Sébastien Labbé's patch for suffix_tree, we can still use the other patch for nfactor_enumerable_word.py, Sébastien think that patch is perfect which I count as a positive review of it. |
|
comment:279
Replying to @kiwifb:
I overlooked that patch, it was not in the list of patches to be applied. I agree it is better. |
|
comment:280
Attachment: 9958_combinat.patch.gz Replying to @jdemeyer:
It was https://github.com/sagemath/sage/issues/9958?action=diff&version=273 but never mind we have it now. |
|
comment:281
Replying to @kiwifb:
Look more carefully, it wasn't :-) |
|
comment:282
You are right I put the wrong patch in the list actually I never updated the list to include the right one, complete oversight. It's good that we are getting this merged now before more confusion arise from the number of patches attached. |
|
comment:283
François and others: thank you for all of the work you did on this ticket. |
|
comment:284
Hi, I am removing my name from the authors list. For three lines of code I wrote, I don't feel as an author at all for such an important ticket. Being a reviewer of the small combinat part is enough and more appropriate. Sébastien |
|
Changed author from François Bissey, Steven Trogdon, Sébastien Labbé, Jeroen Demeyer to François Bissey, Steven Trogdon, Jeroen Demeyer |
|
Merged: sage-5.0.beta0 |
|
comment:286
Just as FYI, though I doubt it matters since the patch still applies, I get before the other patches and configuration. |
|
comment:288
Replying to @kcrisman:
Not a big deal. The patch still applies perfectly. |
From the release notes:
Python 2.7.2 was released on June 11th, 2011.
The Python 2.7 series is scheduled to be the last major version in the 2.x series before 2.x moves into an extended maintenance period. The 2.7 series contains many of the features that were first released in Python 3.1. Improvements in this release include:
Fixes #1159
New spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/python-2.7.2.p1.spkg (diffs for reviewing (without deleted files): attachment: python-2.7.2.p0.diff and attachment: python-2.7.2.p0-p1.diff)
Apply:
Depends on #5852
Depends on #11986
Depends on #12085
Depends on #12096
Depends on #12124
Depends on #11915
CC: @jhpalmieri @nexttime @jasongrout @kcrisman @kini
Component: packages: standard
Author: François Bissey, Steven Trogdon, Jeroen Demeyer
Reviewer: John Palmieri, Karl-Dieter Crisman, Jason Grout, Jeroen Demeyer, Steven Trogdon, Leif Leonhardy, Sébastien Labbé, François Bissey
Merged: sage-5.0.beta0
Issue created by migration from https://trac.sagemath.org/ticket/9958
The text was updated successfully, but these errors were encountered: