Add minimum version of conda gap package #35351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimpase
approved these changes
Mar 26, 2023
|
GAP 4.12.2 is out for quite a while. And the breakage is in a beta so far. |
|
Documentation preview for this PR is ready! 🎉 |
|
Thanks for the review, and the fix upstream! |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #35351 +/- ##
===========================================
- Coverage 88.62% 88.60% -0.03%
===========================================
Files 2148 2148
Lines 398855 398855
===========================================
- Hits 353480 353387 -93
- Misses 45375 45468 +93 see 29 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Since #35093, sage no longer builds with gap 4.11. With this PR the new minimum version is correctly specified for the conda installation. This currently doesn't work as there is no suitable conda package yet, see conda-forge/gap-feedstock#68. However, better fail with a good error message then some random warning during build.
It would be nice if in the future breaking package updates would only happen if conda provides a suitable package.
📝 Checklist
⌛ Dependencies