Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.rings.finite_rings.residue_field: Modularization fixes #35389

Merged
merged 6 commits into from
Apr 23, 2023
Merged

sage.rings.finite_rings.residue_field: Modularization fixes #35389

merged 6 commits into from
Apr 23, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Mar 30, 2023 •
edited

📚 Description

Splitting out the implementations that depend on libraries NTL, PARI, Givaro to separate libraries.

Marking doctests # optional.

This is part of:

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe requested a review from roed314 March 30, 2023 04:23
@mkoeppe mkoeppe self-assigned this Mar 30, 2023
@remyoudompheng remyoudompheng mentioned this pull request Mar 30, 2023
Open
5 tasks
@mkoeppe
Merge tag '10.0.beta8' into residue_field_modularization
f8caeeb 
SageMath version 10.0.beta8, Release Date: 2023-04-06
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: f8caeeb

kwankyu
kwankyu approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 14, 2023

Thank you!

@vbraun vbraun merged commit 15a5078 into sagemath:develop Apr 23, 2023
6 checks passed
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 23, 2023
@mkoeppe mkoeppe deleted the residue_field_modularization branch April 23, 2023 19:55
dwbump pushed a commit to dwbump/sage that referenced this pull request Apr 25, 2023
@dwbmscz
port some of the revisions for sagemath#35389 to sagemath#35501
4c18d8a
@mkoeppe mkoeppe mentioned this pull request May 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@roed314 roed314 Awaiting requested review from roed314

Assignees

@mkoeppe mkoeppe

Labels
c: finite rings t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkoeppe @kwankyu @vbraun