Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification on the MAX_MODULUS of float matrices modulo n #35752

Merged
merged 1 commit into from Jun 21, 2023
Merged

Clarification on the MAX_MODULUS of float matrices modulo n #35752

merged 1 commit into from Jun 21, 2023

Conversation

marizee
Copy link
Contributor

@marizee marizee commented Jun 12, 2023

📚 Description

Improves the documentation to give more precisions on the upper limit MAX_MODULUS of matrix_modn_dense_float.pyx for performances sake.

Fixes #35365

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@vneiger vneiger self-requested a review June 12, 2023 09:28
@vneiger vneiger self-assigned this Jun 12, 2023
@github-actions
Copy link

Documentation preview for this PR (built with commit a6d92ef) is ready! 🎉

@vneiger
Copy link
Contributor

vneiger commented Jun 12, 2023

Looks good to me!

@vbraun vbraun merged commit bcd9128 into sagemath:develop Jun 21, 2023
16 checks passed
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vneiger vneiger vneiger approved these changes

Assignees

@vneiger vneiger

Labels
c: linear algebra p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.

Misleading maximum n value in docstring of matrix_modn_dense_float.pyx
4 participants
@marizee @vneiger @vbraun @mkoeppe