Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification on the MAX_MODULUS of float matrices modulo n #35752

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Clarification on the MAX_MODULUS of float matrices modulo n #35752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/sage/matrix/matrix_modn_dense_double.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ cdef class Matrix_modn_dense_double(Matrix_modn_dense_template):

These are matrices with integer entries mod ``n`` represented as
floating-point numbers in a 64-bit word for use with LinBox routines.
This allows for ``n`` up to `2^{23}`. The analogous
``Matrix_modn_dense_float`` class is used for smaller moduli.
This allows for ``n`` up to `2^{23}`. By default, the analogous
``Matrix_modn_dense_float`` class is used for smaller moduli, specifically
for ``n`` up to `2^{8}`.

Routines here are for the most basic access, see the
``matrix_modn_dense_template.pxi`` file for higher-level routines.
Expand Down
9 changes: 5 additions & 4 deletions src/sage/matrix/matrix_modn_dense_float.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# distutils: library_dirs = CBLAS_LIBDIR
# distutils: include_dirs = CBLAS_INCDIR
r"""
Dense matrices over `\ZZ/n\ZZ` for `n < 2^{11}` using LinBox's ``Modular<float>``
Dense matrices over `\ZZ/n\ZZ` for `n < 2^{8}` using LinBox's ``Modular<float>``

AUTHORS:
- Burcin Erocal
Expand Down Expand Up @@ -44,12 +44,13 @@ include "matrix_modn_dense_template.pxi"

cdef class Matrix_modn_dense_float(Matrix_modn_dense_template):
r"""
Dense matrices over `\ZZ/n\ZZ` for `n < 2^{11}` using LinBox's ``Modular<float>``
Dense matrices over `\ZZ/n\ZZ` for `n < 2^{8}` using LinBox's ``Modular<float>``

These are matrices with integer entries mod ``n`` represented as
floating-point numbers in a 32-bit word for use with LinBox routines.
This allows for ``n`` up to `2^{11}`. The
``Matrix_modn_dense_double`` class is used for larger moduli.
This could allow for ``n`` up to `2^{11}`, but for performance reasons
this is limited to ``n`` up to `2^{8}`, and for larger moduli the
``Matrix_modn_dense_double`` class is used.

Routines here are for the most basic access, see the
``matrix_modn_dense_template.pxi`` file for higher-level routines.
Expand Down