sage.rings: Update # needs
#36152
Merged
sage.rings: Update # needs
#36152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only-tags src/sage/rings/*.{py,pyx}
kwankyu
reviewed
Aug 31, 2023
kwankyu
reviewed
Aug 31, 2023
kwankyu
reviewed
Aug 31, 2023
| sage: L = Localization(R, (a**2 - 3, a)) # optional - sage.rings.finite_rings | ||
| sage: L.fraction_field() # optional - sage.rings.finite_rings | ||
| sage: # needs sage.rings.finite_rings | ||
| sage: R.<a> = GF(5)[] |
There was a problem hiding this comment.
Fixed in 59e556e - a tag is needed, but sage.libs.pari is a better choice.
kwankyu
reviewed
Aug 31, 2023
| @@ -253,19 +253,20 @@ class MPowerSeries(PowerSeries): | |||
| 1 + s + t - s*t + O(s, t)^5 | |||
|
|
|||
|
|
|||
| sage: T = PowerSeriesRing(GF(3),5,'t'); T # optional - sage.rings.finite_rings | |||
| sage: # needs sage.rings.finite_rings | |||
| sage: T = PowerSeriesRing(GF(3),5,'t'); T | |||
There was a problem hiding this comment.
No, not needed; fixed in 733d5c2
kwankyu
reviewed
Aug 31, 2023
kwankyu
reviewed
Aug 31, 2023
| @@ -578,7 +578,7 @@ def PolynomialRing(base_ring, *args, **kwds): | |||
|
|
|||
| sage: R.<w> = PolynomialRing(PolynomialRing(GF(7),'k')); TestSuite(R).run(); R | |||
| Univariate Polynomial Ring in w over Univariate Polynomial Ring in k over Finite Field of size 7 | |||
| sage: ZxNTL = PolynomialRing(ZZ, 'x', implementation='NTL'); TestSuite(ZxNTL).run(skip='_test_pickling'); ZxNTL | |||
| sage: ZxNTL = PolynomialRing(ZZ, 'x', implementation='NTL'); TestSuite(ZxNTL).run(skip='_test_pickling'); ZxNTL # needs sage.libs.ntl | |||
| Univariate Polynomial Ring in x over Integer Ring (using NTL) | |||
| sage: ZxFLINT = PolynomialRing(ZZ, 'x', implementation='FLINT'); TestSuite(ZxFLINT).run(); ZxFLINT | |||
There was a problem hiding this comment.
Maybe, could be splitted.
There was a problem hiding this comment.
OK. I thought the tag is completely out of sight. But it is in TESTS block, and hence not visible anyway.
kwankyu
reviewed
Aug 31, 2023
| @@ -649,6 +650,7 @@ cdef class RealDoubleField_class(sage.rings.abc.RealDoubleField): | |||
|
|
|||
| TESTS:: | |||
|
|
|||
| sage: # needs numpy | |||
| sage: R.<x> = RDF[] | |||
| sage: RDF._factor_univariate_polynomial(x) | |||
kwankyu
reviewed
Aug 31, 2023
| sage: f = (x-1)^3 | ||
| sage: f.roots(ring=CDF) # abs tol 2e-5 | ||
| sage: f = (x-1)^3 # needs numpy | ||
| sage: f.roots(ring=CDF) # abs tol 2e-5 # needs numpy | ||
| [(1.0000065719436413, 1), |
There was a problem hiding this comment.
Why numpy here and below?
There was a problem hiding this comment.
This goes through Polynomial.root, which tries to invoke numpy for low-precision float fields. (It could fall back to using PARI, but this would require a bit of refactoring)
kwankyu
reviewed
Aug 31, 2023
kwankyu
reviewed
Aug 31, 2023
…s to more precise sage.libs.pari; use more block tags
… # needs sage.rings.finite_rings
|
Documentation preview for this PR (built with commit 89e4c05; changes) is ready! 🎉 |
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 2, 2023
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> - Part of: sagemath#29705 - Cherry-picked from: sagemath#35095 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36152 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 4, 2023
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> - Part of: sagemath#29705 - Cherry-picked from: sagemath#35095 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36152 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 5, 2023
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> - Part of: sagemath#29705 - Cherry-picked from: sagemath#35095 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36152 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies