fix E228 then E225 in rings/ #36192
Merged
fix E228 then E225 in rings/ #36192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you checked possible conflicts with #36152 ? |
kwankyu
reviewed
Sep 4, 2023
kwankyu
reviewed
Sep 4, 2023
kwankyu
reviewed
Sep 5, 2023
| @@ -238,7 +238,7 @@ def list(self): | |||
| v = [D.hom([r], codomain=C, check=False) for r in roots] | |||
| else: | |||
| v = [] | |||
| return Sequence(v, universe=self, check=False, immutable=True, cr=v!=[]) | |||
| return Sequence(v, universe=self, check=False, immutable=True, cr=v != []) | |||
|
|
|||
There was a problem hiding this comment.
cr=(v != []) or cr=(v!=[])may be better than inserting spaces.
kwankyu
reviewed
Sep 5, 2023
| @@ -519,7 +519,7 @@ def list(self): | |||
| C = self.codomain() | |||
| D_abs = D.absolute_field('a') | |||
| v = [self(f, check=False) for f in D_abs.Hom(C).list()] | |||
| return Sequence(v, universe=self, check=False, immutable=True, cr=v!=[]) | |||
| return Sequence(v, universe=self, check=False, immutable=True, cr=v != []) | |||
|
|
|||
kwankyu
reviewed
Sep 5, 2023
| else: | ||
| if D == C: | ||
| w = z | ||
| else: | ||
| w = C.zeta(n) | ||
| v = [self([w**k], check=False) for k in Zmod(n) if k.is_unit()] | ||
| return Sequence(v, universe=self, check=False, immutable=True, cr=v!=[]) | ||
| return Sequence(v, universe=self, check=False, immutable=True, cr=v != []) |
kwankyu
reviewed
Sep 5, 2023
| @@ -463,7 +463,7 @@ def subfields(self, degree=0, name=None): | |||
| if to_K is not None: | |||
| to_K = RelativeNumberFieldHomomorphism_from_abs(self.Hom(K), to_K*to_abs) | |||
| ans.append((K, from_K, to_K)) | |||
| ans = Sequence(ans, immutable=True, cr=ans!=[]) | |||
| ans = Sequence(ans, immutable=True, cr=ans != []) | |||
| return ans | |||
kwankyu
reviewed
Sep 5, 2023
| @@ -2077,7 +2077,7 @@ def embeddings(self, K): | |||
| # then it is most natural, so we put it first. | |||
| put_natural_embedding_first(v) | |||
|
|
|||
| self.__embeddings[K] = Sequence(v, cr=v!=[], immutable=True, check=False, universe=self.Hom(K)) | |||
| self.__embeddings[K] = Sequence(v, cr=v != [], immutable=True, check=False, universe=self.Hom(K)) | |||
| return self.__embeddings[K] | |||
|
Otherwise, lgtm. |
|
Documentation preview for this PR (built with commit 39dfddd; changes) is ready! 馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix pycodestyle warnings E228 and E225 in rings
done using autopep8
馃摑 Checklist