Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.combinat.species: Update # needs #36643

Merged
merged 8 commits into from
Dec 6, 2023

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Nov 4, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Nov 4, 2023
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an indentation issue in src/sage/combinat/species/partition_species.py line 145.

       """
        return super().__classcall__(cls, *args, **kwds)

@dcoudert
Copy link
Contributor

dcoudert commented Nov 4, 2023

The last commit breaks doctests.
Actually, we originally have

    def __classcall__(cls, *args, **kwds):
        """
        EXAMPLES::

            sage: P = species.PartitionSpecies(); P
            Partition species
       """
        return super().__classcall__(cls, *args, **kwds)

So I wrongly pointed to the line with return while it's the line with """ that is not properly indented.

@mkoeppe mkoeppe force-pushed the needs_for_sage_combinat_species branch from 36c26bd to 81dfb7b Compare November 4, 2023 18:17
@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 4, 2023

Sorry! I hope I got it right now

Copy link

github-actions bot commented Nov 4, 2023

Documentation preview for this PR (built with commit 81dfb7b; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 5, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants