Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix random doctest failure in generic has_order() function #37102

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Jan 19, 2024

In this simple patch we fix a random test failure in the has_order() function for generic groups.

#sd123

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also have an explicit test for this? Otherwise LGTM.

@yyyyx4 yyyyx4 force-pushed the public/fix_random_failure_in_generic_group_has_order branch from 0da10e3 to 4009f43 Compare January 25, 2024 13:54
@yyyyx4 yyyyx4 requested a review from tscrim January 25, 2024 13:55
Copy link

Documentation preview for this PR (built with commit 4009f43; changes) is ready! 🎉

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 27, 2024
…unction

    
In this simple patch we fix [a random test failure](https://github.com/s
agemath/sage/actions/runs/7577410381/job/20638145383#step:10:4436) in
the `has_order()` function for generic groups.

#sd123
    
URL: sagemath#37102
Reported by: Lorenz Panny
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 29, 2024
…unction

    
In this simple patch we fix [a random test failure](https://github.com/s
agemath/sage/actions/runs/7577410381/job/20638145383#step:10:4436) in
the `has_order()` function for generic groups.

#sd123
    
URL: sagemath#37102
Reported by: Lorenz Panny
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2024
…unction

    
In this simple patch we fix [a random test failure](https://github.com/s
agemath/sage/actions/runs/7577410381/job/20638145383#step:10:4436) in
the `has_order()` function for generic groups.

#sd123
    
URL: sagemath#37102
Reported by: Lorenz Panny
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit ef82f2f into sagemath:develop Feb 2, 2024
17 of 20 checks passed
@yyyyx4 yyyyx4 deleted the public/fix_random_failure_in_generic_group_has_order branch February 3, 2024 12:58
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants