Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sage_setup.clean doctest #37185

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Jan 29, 2024

As reported in https://groups.google.com/g/sage-devel/c/mLtXcaypU3Q/m/jHoVjQ9oAAAJ @kwankyu

This failure was introduced as a side effect of #36591: The pytest discovery of modules disagrees with sage_setup's notion of package directories vs. data directories. We repair it by making sage.tests.books an ordinary package directory (correct because the whole thing is shipped by sagemath-repl).

Fixes #37216

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

github-actions bot commented Feb 3, 2024

Documentation preview for this PR (built with commit c2bb474; changes) is ready! 🎉

@tornaria
Copy link
Contributor

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 11, 2024

Thanks!

@vbraun vbraun merged commit 0319fbb into sagemath:develop Feb 13, 2024
21 of 22 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
@mkoeppe mkoeppe deleted the sage_setup_clean_doctest branch May 5, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test in GH action "build", on file sage_setup/clean.py
3 participants