Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in pycore_long.h for Python <= 3.8. #37194

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

J08nY
Copy link
Contributor

@J08nY J08nY commented Jan 30, 2024

This fixes the same issue as in sagemath/cypari2#146.

Typo was added in dc71bd0.

Copy link
Contributor

@S17A05 S17A05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

Documentation preview for this PR (built with commit a74e59b; changes) is ready! 🎉

@J08nY
Copy link
Contributor Author

J08nY commented Jan 31, 2024

The test failures don't seem to be connected to the change, so hopefully this can get merged.

@S17A05
Copy link
Contributor

S17A05 commented Jan 31, 2024

I'm not sure why the Conda Build & Test for (macos, 3.9) failed, but the general build error is a known issue, see devel and #37185.

@vbraun vbraun merged commit 3212df1 into sagemath:develop Feb 2, 2024
21 of 23 checks passed
@J08nY J08nY deleted the fix/op branch February 2, 2024 21:41
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants