Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/pkgs/{python3,setuptools}: Update fedora distro info #37833

Merged
merged 1 commit into from May 2, 2024
Merged

build/pkgs/{python3,setuptools}: Update fedora distro info #37833

merged 1 commit into from May 2, 2024

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Apr 19, 2024 •
edited

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Apr 19, 2024
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit b1b2fcd; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe mentioned this pull request Apr 19, 2024
Open
5 tasks
@enriqueartal
Copy link
Contributor

It seems to be OK but I have a small issue. In Fedora 39 I cannot actually test the changes since the required version for setuptools is bigger than the system version. I have a virtual machine with Fedora 40, where this could be applied but sagelib does not build, I guess there will be no problem anyway.
I have also one comment. The change python->python3 applies to many other fedora.txt files; in other cases the devel package should also be added to the file since it contains the required files in order to use the system packages. Finally, some packages do not have fedora.txt files while the system packages may exist. Would be interesting to create a PR for this issue?

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 20, 2024

Yes, preparing a PR with such updates would be valuable!

@enriqueartal
Copy link
Contributor

LGTM, I will prepare a PR for more updates. Do you know if it will be possible to deal with the problems with sage/graphs/base/sparse_graph.c, sage/graphs/base/dense_graph.c, sage/graphs/base/static_sparse_backend.c, sage/matroids/lean_matrix.c, and sage/plot/plot3d/implicit_surface.c (see #37537 (comment))?

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 21, 2024

Thanks!

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 21, 2024

Do you know if it will be possible to deal with the problems with sage/graphs/base/sparse_graph.c, sage/graphs/base/dense_graph.c, sage/graphs/base/static_sparse_backend.c, sage/matroids/lean_matrix.c, and sage/plot/plot3d/implicit_surface.c (see #37537 (comment))?

I'll take a look at this in the coming week

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 28, 2024
sagemathgh-37833: build/pkgs/{python3,setuptools}: Update fedora di…
2116f54 
…stro info

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Cherry-picked from sagemath#36181

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37833
Reported by: Matthias Köppe
Reviewer(s): Enrique Manuel Artal Bartolo
@vbraun vbraun merged commit 6e58d87 into sagemath:develop May 2, 2024
18 of 36 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enriqueartal enriqueartal enriqueartal approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: build
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkoeppe @enriqueartal @vbraun