Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/{gcc,gfortran}/spkg-configure.m4: Allow 14.x #37537

Merged
merged 2 commits into from
May 12, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 4, 2024

Fedora 40 already ships GCC 14

Fixes #37698

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit d17b927; changes) is ready! 🎉

@enriqueartal
Copy link
Contributor

I am still testing gcc 14 with no success. Besides these changes, I needed to use #35148 and some patches in fedora 40 for linbox. The problems are in sagelib, maybe here:

[spkg-install]     sage/graphs/base/static_sparse_backend.c:15899:75: warning: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int' [-Wsign-compare]
[spkg-install]     15899 |     __pyx_t_1 = (((__pyx_v_self->g_rev->neighbors[__pyx_v_u])[__pyx_v_i]) != __pyx_v_v);
[spkg-install]           |                                                                           ^~
[spkg-install]     sage/graphs/base/dense_graph.c: In function '__pyx_pf_4sage_6graphs_4base_11dense_graph_17DenseGraphBackend_6has_edge':
[spkg-install]     sage/graphs/base/dense_graph.c:18267:103: error: passing argument 1 of '__pyx_f_4sage_6graphs_4base_11dense_graph_17DenseGraphBackend__has_labeled_edge_unsafe' from incompatible pointer type [-Wincompatible-pointer-ty
pes]
[spkg-install]     18267 |   __pyx_t_2 = __pyx_f_4sage_6graphs_4base_11dense_graph_17DenseGraphBackend__has_labeled_edge_unsafe(((struct __pyx_obj_4sage_6graphs_4base_7c_graph_CGraphBackend *)__pyx_v_self), __pyx_v_u_int, __pyx_v_v_int,
 Py_None); if (unlikely(__pyx_t_2 == ((int)-1))) __PYX_ERR(0, 702, __pyx_L1_error)

@enriqueartal
Copy link
Contributor

After last beta, 'sagelib` is not built. I attach the log (of an incremental build); those files and lines are to blame, apparently:
sagelib-10.4.beta3.log

sage/graphs/base/sparse_graph.c:17473:94: error: passing argument 1 of 
'__pyx_f_4sage_6graphs_4base_12sparse_graph_11SparseGraph_add_arc_label_unsafe'
from incompatible pointer type [-Wincompatible-pointer-types]```
sage/graphs/base/dense_graph.c:18268:103: error: passing argument 1 of 
'__pyx_f_4sage_6graphs_4base_11dense_graph_17DenseGraphBackend__has_labeled_edge_unsafe' 
from incompatible pointer type [-Wincompatible-pointer-types]

Same file in 18319:94.

sage/graphs/base/sparse_graph.c:21822:105: error: passing argument 1 of 
'__pyx_f_4sage_6graphs_4base_12sparse_graph_18SparseGraphBackend__has_labeled_edge_unsafe' 
from incompatible pointer type [-Wincompatible-pointer-types]

Same file 21879:96, 22605:97. 22668:90

sage/graphs/base/static_sparse_backend.c:15831:116: error: passing argument 1 of 
'__pyx_f_4sage_6graphs_4base_21static_sparse_backend_18StaticSparseCGraph_next_out_neighbor_unsafe' 
from incompatible pointer type [-Wincompatible-pointer-types]

Same file 19644:109 (arguments 1 and 4), 20154:116, 24845:119

sage/matroids/lean_matrix.c:36372:83: error: passing argument 1 of 
'__pyx_f_4sage_8matroids_11lean_matrix_13TernaryMatrix_is_nonzero' 
from incompatible pointer type [-Wincompatible-pointer-types]

Smae file 43136:86

 sage/plot/plot3d/implicit_surface.c:11783:21: error: assignment to 'PyObject *' {aka 'struct _object *'} 
from incompatible pointer type 'struct __pyx_obj_4sage_4plot_6plot3d_16implicit_surface_VertexInfo 
*' [-Wincompatible-pointer-types]

Same file 12340:21, 13593:21

@erentar
Copy link

erentar commented May 3, 2024

I am still testing gcc 14 with no success. Besides these changes, I needed to use #35148 and some patches in fedora 40 for linbox. The problems are in sagelib, maybe here:

[spkg-install]     sage/graphs/base/static_sparse_backend.c:15899:75: warning: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int' [-Wsign-compare]
[spkg-install]     15899 |     __pyx_t_1 = (((__pyx_v_self->g_rev->neighbors[__pyx_v_u])[__pyx_v_i]) != __pyx_v_v);
[spkg-install]           |                                                                           ^~
[spkg-install]     sage/graphs/base/dense_graph.c: In function '__pyx_pf_4sage_6graphs_4base_11dense_graph_17DenseGraphBackend_6has_edge':
[spkg-install]     sage/graphs/base/dense_graph.c:18267:103: error: passing argument 1 of '__pyx_f_4sage_6graphs_4base_11dense_graph_17DenseGraphBackend__has_labeled_edge_unsafe' from incompatible pointer type [-Wincompatible-pointer-ty
pes]
[spkg-install]     18267 |   __pyx_t_2 = __pyx_f_4sage_6graphs_4base_11dense_graph_17DenseGraphBackend__has_labeled_edge_unsafe(((struct __pyx_obj_4sage_6graphs_4base_7c_graph_CGraphBackend *)__pyx_v_self), __pyx_v_u_int, __pyx_v_v_int,
 Py_None); if (unlikely(__pyx_t_2 == ((int)-1))) __PYX_ERR(0, 702, __pyx_L1_error)

i can attest that givaro fails. will try with #35148

@vbraun
Copy link
Member

vbraun commented May 5, 2024

Lets merge this and work on fixing the breakage in separate PRs

@enriqueartal
Copy link
Contributor

For the record, I summarize my tests, not yet successul, but with some progress:

The remaining errors in sagelib come from sage/plot/plot3d/implicit_surface.c.

Thanks for the work.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 5, 2024
…14.x

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fedora 40 already ships GCC 14

Fixes sagemath#37698

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37646
    
URL: sagemath#37537
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2024
…14.x

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fedora 40 already ships GCC 14

Fixes sagemath#37698

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37646
    
URL: sagemath#37537
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2024
…14.x

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fedora 40 already ships GCC 14

Fixes sagemath#37698

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37646
    
URL: sagemath#37537
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
…14.x

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fedora 40 already ships GCC 14

Fixes sagemath#37698

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37646
    
URL: sagemath#37537
Reported by: Matthias Köppe
Reviewer(s):
@vbraun vbraun merged commit d347729 into sagemath:develop May 12, 2024
18 of 36 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fedora 40 and gcc 14
4 participants