add important note in Step 2 about how WSL users should use the Linux git #38040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
reviewed
May 20, 2024
|
@chrisxu3 I think our use of |
…oeppe's suggestion)
mkoeppe
reviewed
May 20, 2024
| @@ -153,6 +153,10 @@ in the Installation Guide. | |||
|
|
|||
| 2. Clone the sources with `git`: | |||
|
|
|||
| - [Windows] **The Sage source tree contains symbolic links, which use UNIX line endings. | |||
There was a problem hiding this comment.
"symbolic links" and "UNIX line endings" are two separate, unrelated things
There was a problem hiding this comment.
Maybe it should be clarified that it's using Windows line endings that ends up breaking the symlinks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies
See #37117 #38039 for the details, which are regarding errors that you run into if you're using WSL and don't use Linux git to clone the repo.