-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch from genbg
to genbgL
in nauty_genbg
to generate larger bipartite graphs.
#38621
Open
dcoudert
wants to merge
1
commit into
sagemath:develop
Choose a base branch
from
dcoudert:graphs/use_nauty_genbgL
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Documentation preview for this PR (built with commit 0dc4a54; changes) is ready! 🎉 |
mkoeppe
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 8, 2024
… generate larger bipartite graphs. Fixes sagemath#38618. `genbg` was limited to bipartite graphs with up to 32 vertices. Using `genbgL`, we can go to 64 vertices. Note that in the doctests, we use the form `...genbg...` as currently lines starting with `>A` contain `genbgL` while lines starting with `>E` contain `genbg`. using this formulation, we are on the safe side. On the way, we fix the documentation of `digraphs.tournaments_nauty()`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38621 Reported by: David Coudert Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 8, 2024
… generate larger bipartite graphs. Fixes sagemath#38618. `genbg` was limited to bipartite graphs with up to 32 vertices. Using `genbgL`, we can go to 64 vertices. Note that in the doctests, we use the form `...genbg...` as currently lines starting with `>A` contain `genbgL` while lines starting with `>E` contain `genbg`. using this formulation, we are on the safe side. On the way, we fix the documentation of `digraphs.tournaments_nauty()`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38621 Reported by: David Coudert Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 10, 2024
… generate larger bipartite graphs. Fixes sagemath#38618. `genbg` was limited to bipartite graphs with up to 32 vertices. Using `genbgL`, we can go to 64 vertices. Note that in the doctests, we use the form `...genbg...` as currently lines starting with `>A` contain `genbgL` while lines starting with `>E` contain `genbg`. using this formulation, we are on the safe side. On the way, we fix the documentation of `digraphs.tournaments_nauty()`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38621 Reported by: David Coudert Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38618.
genbg
was limited to bipartite graphs with up to 32 vertices. UsinggenbgL
, we can go to 64 vertices.Note that in the doctests, we use the form
...genbg...
as currently lines starting with>A
containgenbgL
while lines starting with>E
containgenbg
. using this formulation, we are on the safe side.On the way, we fix the documentation of
digraphs.tournaments_nauty()
.📝 Checklist
⌛ Dependencies