This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
Cache public worksheets for performance #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,6 +153,17 @@ def __init__(self, dir, user_manager = None): | |||
| W = WorksheetDict(self) | |||
| self.__worksheets = W | |||
|
|
|||
| # Store / Refresh public worksheets | |||
| for id_number in os.listdir(self.__storage._abspath(self.__storage._user_path("pub"))): | |||
There was a problem hiding this comment.
I wonder what tradeoff there would be between using the list of user visible worksheets for the pub user compared to using os.listdir. Is the set of "viewable worksheets" for the pub user exactly the published worksheets?
jasongrout
added a commit
that referenced
this pull request
Jan 14, 2012
Cache public worksheets for performance
|
Looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Google Code Issue 71: http://code.google.com/p/sagenb/issues/detail?id=71