-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added patches for Python 2.4 and 2.5 #23
Conversation
Python 2.4 builds were failing due to a syntax error (see #21). This patch hopefully solves the issue.
Doesn't seem to solve the issue if I install from my master branch or copy the patch to ~/.pythonz/. It seems it is not applying the patch. Is there any patch list or something else that must be added? |
Exactly :-) Look here: https://github.com/saghul/pythonz/blob/master/pythonz/installer/pythoninstaller.py#L197 you'll want to skip the "all verisons" patch for python <= 2.5. Bonus points if you also take the fix for 2.5 ;-) |
Damn, last commit message should refer to issue #21 of course. I am trying to fix it for 2.5 too :) |
No problem, I can squash the commits later. Btw, GitHub doesn't send a notification when you add new commits, so leave a comments when you are done :-) |
All right. Anyway, it seems that I am getting other kind of errors when trying to build 2.5 ("gcc: error: directory": No such file or directory") but as I said I am going to test them in another system and open a new issue. May you already merge this or shall I add the 2.5 patch anyway? |
Lets merge them both when ready :-) |
Ready, I also added the patch for Python 2.5. I still cannot install it in the system I use daily though :( (see #24). |
Awesome, thanks! I'll try it out myself and merge it. Your problem may be related to some paths in Arch, we can solve that later :-) |
I squashed the commits into one and merged them here: e6ec2ad FYI, I could build 2.5 just fine on OSX so I guess your problem has to do with Arch somehow. |
Thank you very much! |
Python 2.4 builds were failing due to a syntax error (see #21). This
patch hopefully solves the issue.