Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added patches for Python 2.4 and 2.5 #23

Closed
wants to merge 3 commits into from
Closed

Added patches for Python 2.4 and 2.5 #23

wants to merge 3 commits into from

Conversation

astrojuanlu
Copy link
Contributor

Python 2.4 builds were failing due to a syntax error (see #21). This
patch hopefully solves the issue.

Python 2.4 builds were failing due to a syntax error (see #21). This
patch hopefully solves the issue.
@astrojuanlu
Copy link
Contributor Author

Doesn't seem to solve the issue if I install from my master branch or copy the patch to ~/.pythonz/. It seems it is not applying the patch. Is there any patch list or something else that must be added?

@saghul
Copy link
Owner

saghul commented Jan 28, 2013

Exactly :-) Look here: https://github.com/saghul/pythonz/blob/master/pythonz/installer/pythoninstaller.py#L197 you'll want to skip the "all verisons" patch for python <= 2.5.

Bonus points if you also take the fix for 2.5 ;-)

This way the patch added in 7270a38 is actually applied. Fixes #23.
@astrojuanlu
Copy link
Contributor Author

Damn, last commit message should refer to issue #21 of course. I am trying to fix it for 2.5 too :)

@saghul
Copy link
Owner

saghul commented Jan 29, 2013

No problem, I can squash the commits later. Btw, GitHub doesn't send a notification when you add new commits, so leave a comments when you are done :-)

@astrojuanlu
Copy link
Contributor Author

All right. Anyway, it seems that I am getting other kind of errors when trying to build 2.5 ("gcc: error: directory": No such file or directory") but as I said I am going to test them in another system and open a new issue. May you already merge this or shall I add the 2.5 patch anyway?

@saghul
Copy link
Owner

saghul commented Jan 29, 2013

Lets merge them both when ready :-)

@astrojuanlu
Copy link
Contributor Author

Ready, I also added the patch for Python 2.5. I still cannot install it in the system I use daily though :( (see #24).

@saghul
Copy link
Owner

saghul commented Jan 30, 2013

Awesome, thanks! I'll try it out myself and merge it. Your problem may be related to some paths in Arch, we can solve that later :-)

@saghul
Copy link
Owner

saghul commented Jan 31, 2013

I squashed the commits into one and merged them here: e6ec2ad FYI, I could build 2.5 just fine on OSX so I guess your problem has to do with Arch somehow.

@saghul saghul closed this Jan 31, 2013
@astrojuanlu
Copy link
Contributor Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants