Allow Python classes to inherit from pyuv types. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -210,7 +210,7 @@ | |||
| 0, /*tp_getattro*/ | |||
| 0, /*tp_setattro*/ | |||
| 0, /*tp_as_buffer*/ | |||
| Py_TPFLAGS_DEFAULT, /*tp_flags*/ | |||
| Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE, /*tp_flags*/ | |||
There was a problem hiding this comment.
The Request objects are not exposed, you can't instantiate them, they are returned to you, so I don't want to make them extendable.
| @@ -246,7 +246,7 @@ | |||
| 0, /*tp_getattro*/ | |||
| 0, /*tp_setattro*/ | |||
| 0, /*tp_as_buffer*/ | |||
| Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC, /*tp_flags*/ | |||
| Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE | Py_TPFLAGS_HAVE_GC, /*tp_flags*/ | |||
There was a problem hiding this comment.
Since Handle is not exposed we don't need this either, do we?
|
Great work, thanks! Can you double check the flags for the Handle class? Other than that this looks good to go :-) |
|
Let me know if i got all your requests done.. Thanks! |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attached patch allows Python classes to inherit from pyuv extension types.