Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for sql transactions in tjs:sqlite #511

Closed
KaruroChori opened this issue May 6, 2024 · 5 comments · Fixed by #536
Closed

No support for sql transactions in tjs:sqlite #511

KaruroChori opened this issue May 6, 2024 · 5 comments · Fixed by #536

Comments

@KaruroChori
Copy link
Contributor

Most query builders and ORM libraries assume there is support for transactions on the database driver.
From what I can tell this is missing from the custom integration of txiki.

Such change would meaningfully improve the ecosystem of libraries which can be made to work with this runtime.

@saghul
Copy link
Owner

saghul commented May 6, 2024

Absolutely! I strated with the bare minimum, with the intention to complete things at a later stage.

Do you have an API in mind we can go over? I got heavily inspired by Bun's when made the txiki.js module.

@KaruroChori
Copy link
Contributor Author

Both better-sqlite3 & bun provide support for transactions, so doing something more or less in line with their implementation would be best in my opinion.
Mostly because the process of integrating dirzzle/kysely/prisma/whatever at that point is just a bit more effort than copy&paste :D.

@saghul
Copy link
Owner

saghul commented May 6, 2024

Got it 👍 No ETA at the moment, but it's certainly close in the roadmap.

@KaruroChori
Copy link
Contributor Author

Btw, a lot of libraries I tried were not compatible because of bellard/quickjs#261 which has been just merged to quickjs. What is the general process for patches/fixes in this repo? quickjs <-> quickjs-ng -> txiki.js?

@saghul
Copy link
Owner

saghul commented May 6, 2024

I'll port the fox to NG, then bump it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants