Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass unsafe vault envs #10

Merged
merged 2 commits into from
Sep 7, 2020
Merged

Pass unsafe vault envs #10

merged 2 commits into from
Sep 7, 2020

Conversation

sagikazarmark
Copy link
Owner

Pass VAULT_ env vars to the test.

Note: regardless of using PassUnsafeEnv, it does seem to effect incrementality.

See the following commands:

❯ plz build --profile experimental //remote/vault:test
Build finished; total time 310ms, incrementality 100.0%. Outputs:
//remote/vault:test:
  plz-out/bin/remote/vault/test
❯ VAULT_TOKEN=asd plz build --profile experimental //remote/vault:test
Build finished; total time 19.48s, incrementality 0.0%. Outputs:
//remote/vault:test:
  plz-out/bin/remote/vault/test

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark merged commit 5019226 into master Sep 7, 2020
@sagikazarmark sagikazarmark deleted the pass-vault-envs branch September 7, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant