Cleaning up connection and v2 secrets #18
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently experimenting with viperx / vault provider. Over the course of working with this the last few days I've noticed a few things I addressed in this PR and I wanted to share. I don't think this is complete at this time, but wanted to open it for feedback. I'd like to move in the same direction as the project rather than fork if possible.
High level changes
My opinion is we should allow overriding but I think we should change the interface forAddRemoteProvider
method to accept a config struct for the provider, that it will attach to that provider instantiation.Whoops, just realized this is part of Viper proper. Thinking about what a better solution would be.
kv2 looks like
Right now I'm making that choice based on if data is found, but I think it would be best to validate both data and metadata are present before assuming kv2.
Would love your feedback on these, or gauge your interest on moving forward. Happy to help with making this a more powerful plugin.