Merge pull request #412 from saguijs/set-minchunks-value-in-the-commo…

…n-chunks-plugin-config Set minChunks to 2 by default in CommonChunksPlugin
saguijs · Nov 8, 2017 · ebc2d85 · ebc2d85
2 parents 19ff8e7 + ffd0864
commit ebc2d85
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/configure-webpack/build-pages-config.js b/src/configure-webpack/build-pages-config.js
@@ -43,7 +43,7 @@ function configurePlugins (pages, action) {
   })
 
   if (pages.length > 1) {
-    plugins.push(new optimize.CommonsChunkPlugin({ name: 'common' }))
+    plugins.push(new optimize.CommonsChunkPlugin({ name: 'common', minChunks: 2 }))
   }
 
   return plugins

diff --git a/src/configure-webpack/build-pages-config.spec.js b/src/configure-webpack/build-pages-config.spec.js
@@ -96,6 +96,13 @@ describe('pages webpack preset', function () {
       const commons = webpackConfig.plugins.filter((plugin) => plugin instanceof optimize.CommonsChunkPlugin)
       expect(commons.length).equal(1)
     })
+
+    it('should set minChunks to 2 in the CommonsChunkPlugin', function () {
+      const webpackConfig = buildPagesConfig(['index', 'demo'], baseConfig)
+
+      const commons = webpackConfig.plugins.filter((plugin) => plugin instanceof optimize.CommonsChunkPlugin)
+      expect(commons[0].minChunks).equal(2)
+    })
   })
 
   describe(`when action is "${actions.BUILD}"`, () => {