This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Add support to Library projects #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've reached a point where build and test is working but the development environment is still sub-par. For this feature to be merged I need a way of having a demo page that can be compiled as the result of the build. |
|
Something that I can try is to allow to have more than one webpack configuration at once while building. Of-course this would be handled internally transparently. This would allow Sagui to have both "pages" which would be use to create the demo environment and "library" to define how to distribute it. |
This will allow us to have the Demo environment side-by-side with the building of the library. Unfortunately this commit breaks the development environment, but that should be an easy fix. I think the development environment should use only the pages based webpack configuration. Awesome!
This solution has a slight disadvantage, if running either library or pages, the assets are served in the root, otherwise we get different relative paths based on the output path.
pirelenito
added a commit
that referenced
this pull request
Feb 28, 2016
Add support to Library projects (closes #8)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.