Mimic how Node scans for modules © #376
Conversation
|
@moriaam, as we discussed, this should fix the problem you are having. |
|
|
||
| describe('super test', function() { | ||
| it('should work', function() { | ||
| expect(MyProject.batata()).toEqual('sucesso') |
There was a problem hiding this comment.
Is this Portuguese as well, or just Italian?
| import batata from 'batata' | ||
| import pastel from 'pastel' | ||
|
|
||
| export default { |
There was a problem hiding this comment.
It’s not clear to me how this example tests the problem at hand.
pirelenito
force-pushed
the
mimic-node-module-scan
branch
2 times, most recently
from
59202b7
to
64a39a2
Compare
|
@xaviervia I just updated the tests so that they are more descriptive. I also noticed that I didn't commit all the required files (because they were being git ignored). |
pirelenito
force-pushed
the
mimic-node-module-scan
branch
2 times, most recently
from
5c15c63
to
a3726d4
Compare
|
Also, do you all agree this should be a major version? It could be considered a bug as well... I'm not 100% sure to be honest. |
|
@moriaam, you are not a contributor to Sagui, but I would also like to hear your thoughts. Do you think this is a breaking change? |
|
It could as well be considered a bug... |
|
I wanna say bugfix but it can mess up other projects so go safe with a major version. |
|
Interestingly, I wonder if we should also do the same as https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/config/webpack.config.dev.js#L89 |
- Node modules takes precedence when colliding names; - Respects nested dependencies (This safely allows multiple versions of the same library to co-exist in a project);
pirelenito
force-pushed
the
mimic-node-module-scan
branch
from
a3726d4
to
8562708
Compare
pirelenito
changed the title
|
This is ready for the final review! Lets keep the same behavior as Node.js! |
|
Me and @npejo also tested this change in a big project and it worked fine. I'm merging and doing a major release. |
More information: https://webpack.js.org/configuration/resolve/#resolve-modules
This will require a major version bump.