-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Box2D integration: Add BipedalWalker, BipedalWalkerHardcore #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Alicia1529
force-pushed
the
bipedal_walker
branch
from
September 6, 2022 19:48
1f8ab6d
to
7acbb1d
Compare
@@ -178,6 +178,7 @@ void LunarLanderEnv::ResetBox2d(std::mt19937* gen) { | |||
rjd.bodyB = legs_[index]; | |||
rjd.localAnchorA.SetZero(); | |||
rjd.localAnchorB = Vec2(sign * kLegAway / kScale, kLegDown / kScale); | |||
rjd.referenceAngle = sign * 0.05f; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the bug is copied from here
Trinkle23897
previously approved these changes
Sep 16, 2022
tl; dr: we found using box2d_py-2.3.5 can result in no precision difference. For the following PR we would like to upgrade box2d to 2.4 |
Trinkle23897
approved these changes
Sep 16, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Box2D environments: BipedalWalker, BipedalWalkerHardcore
Simplified version: