Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gym 0.26.0 #205

Merged
merged 34 commits into from
Oct 18, 2022
Merged

Support Gym 0.26.0 #205

merged 34 commits into from
Oct 18, 2022

Conversation

Markus28
Copy link
Collaborator

No description provided.

@Markus28 Markus28 marked this pull request as draft October 14, 2022 21:15
@Trinkle23897
Copy link
Collaborator

@Markus28 can you remove mjc-mwe and use gym>=0.26 for mujcoo_gym_alignment_test?

@Markus28
Copy link
Collaborator Author

Markus28 commented Oct 17, 2022

Do you mean I should use the gym implementation of mujoco environments to compare to envpool in mujoco_gym_align_test? Will this work (i.e. are they actually implemented equivalently)? What version of the mujoco environments would that be?

@Trinkle23897
Copy link
Collaborator

Yes, v4 comparing to v4. Mjc-Mwe was created when that huge mujoco v4 pr hadn’t been merged.

@Trinkle23897 Trinkle23897 marked this pull request as ready for review October 18, 2022 04:13
@Trinkle23897 Trinkle23897 merged commit f674037 into sail-sg:main Oct 18, 2022
@51616 51616 mentioned this pull request Oct 30, 2022
9 tasks
Trinkle23897 pushed a commit that referenced this pull request Oct 31, 2022
Handle interface changes from gym >= 0.26 based on #205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants