-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples now support gym 0.26 #215
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3a0f014
examples now support gym 0.26
51616 b27563b
update reset as well
poringz e4862ad
Apply suggestions from code review
Trinkle23897 c333ace
update sb3 example
51616 93f27ce
update sb3 example
51616 09ee765
sb3 example lint
poringz 664c5cf
Merge branch 'main' into main
Trinkle23897 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,11 +16,15 @@ | |
See https://envpool.readthedocs.io/en/latest/content/xla_interface.html | ||
""" | ||
|
||
import gym | ||
import jax.numpy as jnp | ||
from jax import jit, lax | ||
from packaging import version | ||
|
||
import envpool | ||
|
||
is_legacy_gym = version.parse(gym.__version__) < version.parse("0.26.0") | ||
|
||
|
||
def policy(states: jnp.ndarray) -> jnp.ndarray: | ||
return jnp.zeros(states.shape[0], dtype=jnp.int32) | ||
|
@@ -35,14 +39,20 @@ def gym_sync_step() -> None: | |
def actor_step(iter, loop_var): | ||
handle0, states = loop_var | ||
action = policy(states) | ||
handle1, (new_states, rew, done, info) = step(handle0, action) | ||
if is_legacy_gym: | ||
handle1, (new_states, rew, done, info) = step(handle0, action) | ||
else: | ||
handle1, (new_states, rew, term, trunc, info) = step(handle0, action) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. have you tested this for new gym version? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. It works with both gym=0.26 and gym=0.21. |
||
return (handle1, new_states) | ||
|
||
@jit | ||
def run_actor_loop(num_steps, init_var): | ||
return lax.fori_loop(0, num_steps, actor_step, init_var) | ||
|
||
states = env.reset() | ||
if is_legacy_gym: | ||
states = env.reset() | ||
else: | ||
states, _ = env.reset() | ||
run_actor_loop(100, (handle, states)) | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw is it possible to work out-of-box if we don't add
legacy_wrap
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the wrap, it wouldn't work with gym=0.26 using the latest version of sb3 on pip.