Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Web-links hardly readable, because they are rendered in dark blue #186

Closed
Olf0 opened this issue Apr 3, 2023 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@Olf0
Copy link
Collaborator

Olf0 commented Apr 3, 2023

SailfishOS:Chum GUI application VERSION (<Top pulley> → About): All 0.5.x and 0.6.0

BUG DESCRIPTION

Most web-links are hardly readable when using a dark launcher background, because they are rendered in dark blue on most pages. I observe this regularly on the page for a specific issue and on the page for a specific release. I believe I also saw this on other pages (they rarely contain embedded web-links), but the "About" page is fine; web-links there are rendered in turquoise, which is well visible on both dark and light backgrounds.

STEPS TO REPRODUCE

Look at pages for an individual issue or an individual release with embedded web-links, especially when the text of the links is long. Compare this to the rendering of web-links on the "About" page.

Suggestion

Let all QML pages render web-links in the turquoise colour they have on the "About" page.

@Olf0 Olf0 added the bug Something isn't working label Apr 3, 2023
@Olf0
Copy link
Collaborator Author

Olf0 commented Apr 3, 2023

Screenshots depicting this issue

  • Bad, displaying this issue
    Screenshot_20230403_001
  • Good, showing the "About" page
    Screenshot_20230403_002
  • Even worse when a small font is used
    Screenshot_20230403_003

Olf0 added a commit that referenced this issue May 16, 2023
…ssue #186 (#201)

[IssuePage.qml] Add `linkColor: Theme.highlightColor` in order to fix issue #186
Olf0 added a commit that referenced this issue May 16, 2023
… issue #186 (#202)

[ReleasePage.qml] Add `linkColor: Theme.highlightColor` trying to fix issue #186
@Olf0 Olf0 closed this as completed in 246d0ee May 16, 2023
@Olf0
Copy link
Collaborator Author

Olf0 commented Jul 20, 2023

Unfortunately above mentioned commits (as part of PRs #200, #201 and #202) did not resolve this issue.

@Olf0 Olf0 reopened this Jul 20, 2023
@nephros
Copy link
Contributor

nephros commented Aug 23, 2023

From https://doc.qt.io/qt-5/qml-qtquick-text.html#linkColor-prop

This property works with the StyledText textFormat, but not with RichText. Link color in RichText can be specified by including CSS style tags in the text.

As the Label in IssuePage.qml uses RichText (because it displays a HTML page/snippet), the only way to influence link color is to inject the appropriate CSS either when creating the issue, or when updating the model.

nephros pushed a commit to nephros/sailfishos-chum-gui that referenced this issue Aug 23, 2023
@nephros
Copy link
Contributor

nephros commented Aug 23, 2023

Please see https://github.com/nephros/sailfishos-chum-gui/tree/fix-186 for a quick fix. I can make a PR if that is an acceptable change.

@rinigus
Copy link
Contributor

rinigus commented Aug 23, 2023

If it works, it is fine by me :)

@Olf0
Copy link
Collaborator Author

Olf0 commented Aug 24, 2023

Excellent, thank you @nephros!

Edit: Is looking good in v0.6.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants