-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[osc] Use busybox compatible commands for completion #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please submit the patch to upstream.
- typeset -i ctime=$(command date -d "$(command stat -c '%z' ${projects})" +'%s') | ||
- typeset -i now=$(command date -d now +'%s') | ||
+ typeset -i ctime=$(command stat -c '%Z' ${projects}) | ||
+ typeset -i now=$(command date -D -F +'%s') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the competition when not using busybox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah well which involves installing gnu-coreutils - which probably will break stuff i a lot of places but I haven't tried.
Anyway, turns out an option-less call works for BB and GNU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing coreutils doesn't break anything it just requires you to replace the busybox-symlink packages with coreutils.
Alrighty: openSUSE/osc#1487 |
Now that the change is upstream, is there a burning need for this one or should we just wait for a new upstream release to be synced? Seems like they are getting done relatively often. |
Fine! Closing this, hoping for a bump soonish ;) |
I know it's a bit trivial, but non-busybox-compatible use of
date(1)
is very annoying when using tab-command-completion
Fixes this behaviour: