Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robustness for duplicate ids, pimplification etc #5

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Robustness for duplicate ids, pimplification etc #5

merged 8 commits into from
Aug 13, 2024

Conversation

pvuorela
Copy link
Contributor

Multiple commits here:

  • Started by noticing qtgrilo may crash the application if the query results have entries with duplicate ids. Added protection for that.
  • Had already album artist getter for completeness of the api
  • Wanted to add some logs on how long queries take. Adding timer member variable made jolla-mediaplayer crash on ABI change. Annoyed enough to just pimplify the classes now.
  • Added a simple optimization related to above for the initial fetch. The enhancement isn't that drastic but it's simple.

@pvuorela
[qtgrilo] Warn if duplicate entries are detected on a model. JB#62391
c2c8ae9 
This may lead to crashes when media item get deleted by their id
so better make it known that something unexpected is happening.
@pvuorela
Add .so files to .gitignore
534a5f1
@pvuorela
[qtgilo] Add album artist to GriloMedia API. JB#62391
262512c 
For completeness if nothing else. Likelihood that this is going to be
needed.
@pvuorela
Move some member variables private which don't need to be protected
ce95b11
spiiroin
spiiroin approved these changes Aug 13, 2024
View reviewed changes
src/grilodatasource.cpp Outdated Show resolved Hide resolved
src/grilobrowse.cpp Outdated Show resolved Hide resolved
src/grilodatasource.cpp Outdated Show resolved Hide resolved
@pvuorela
Avoid using protected member variables from base class
5a60181 
Harder to follow and makes pimplifying harder
@pvuorela
[qtgrilo] Pimplify classes. JB#62391
8eceb9b
@pvuorela
[qtgrilo] Optimize the first query a bit. JB#62391
74fc672 
We should be sure that the initial population doesn't need to
move any existing rows, thus we can just skip looking for them.
@pvuorela
Clean up spec and bump version
2463018
@pvuorela pvuorela merged commit b94550f into master Aug 13, 2024
@pvuorela pvuorela deleted the robustness branch August 13, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiiroin spiiroin spiiroin approved these changes

@mlehtima mlehtima Awaiting requested review from mlehtima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvuorela @spiiroin