[sensorfw] Activate sensors on sensorfwd restart. Fixes JB#41999 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvuorela
reviewed
May 7, 2024
Sometimes lipstick does not react to orientation changes and sensorfwd restarts do not help. Looks the fault is triggered when sensorfwd is not running or orientation sensor is not available during lipstick startup. The reason is that m_attemptRestart flag is set only when a start attempt fails due to sensorfwd not being present - within a conditional block that is not entered until sensorfwd has been seen to be available. Which then means that any initial start failure can get locked in, and no retries are made by qtsensors code within the application's life time. Rename m_attemptRestart to m_startRequested. Set/clear it unconditionally on start()/stop() call. When sensorfwd startup is detected, make an attempt to start flagged sensors. Also drop the practically unused "running" member variable. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb41999_initial_start
branch
from
43b351d
to
1ac3e42
Compare
pvuorela
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes lipstick does not react to orientation changes and sensorfwd restarts do not help. Looks the fault is triggered when sensorfwd is not running or orientation sensor is not available during lipstick startup. The reason is that m_attemptRestart flag is set only when a start attempt fails due to sensorfwd not being present - within a conditional block that is not entered until sensorfwd has been seen to be available. Which then means that any initial start failure can get locked in, and no retries are made by qtsensors code within the application's life time.
When application calls sensor start, always set m_attemptRestart. So that an attempt is made to start the sensor whenever sensorfwd startup is detected, regardless of whether it succeeded earlier or not.