SmartResize only on thumbnails

[anarcat]

I've tried switching from img_processor = 'ResizeToFit' (commented out, actually, assuming that's the default) to img_processor = 'SmartResize' after to confirm this comment. turns out it's true: the "normal" sized images are cropped when using the latter, but not the former.

example, with ResizeToFit:

with SmartResize:

notice how the left building is chopped off? here's the original image (or a screenshot of it, actually, because the original is too big for GH) for comparison:

it seems to me the main view shouldn't be cropped... does that make sense?

[saimn]

I think ResizeToFit respects the original aspect ratio, even if the width (or height?) must be smaller, whereas SmartResize respects the size given in input, cropping the dimension that is too big. Does that makes sense ?

[anarcat]

hmm... okay, that makes sense. is there, however, a way to avoid cropping the full images yet still use SmartResize for thumbnails? In other words, it would be great if there would be different processors for thumbnails vs normal images. It seems to be what you're saying in #64, but I'm not sure...

[saimn]

Thumbnails are not created with pilkit's processors, but they are created from the resized image. So currently the answer is no.

[anarcat]

okay, that makes sense i guess.. i've changed the title to clarify this might be just a feature request then....

i guess this would mean double-processing which is why it's not done by default?