sixel_frame_resize(): If width and height are unchanged, nothing to do. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This significantly reduces floating-point calculations when used with, e.g., w3m.
rokuyama
added a commit
to rokuyama/w3m
that referenced
this pull request
Sep 2, 2022
With this fix combined with fix to libsixel: saitoha/libsixel#170 browsing on slow machines (e.g., when floating-point calculation is emulated by kernel) gets significantly speed up. Note that if i->cache->a_width (i->cache->a_height) is zero, width (height) should be set to zero. Otherwise, image in screen boundary (i.e., partially displayed) becomes strangely resized.
|
@rokuyama, you might want to check out #154, and open a copy of your PR at https://github.com/libsixel/libsixel. |
bptato
pushed a commit
to bptato/w3m
that referenced
this pull request
Jul 29, 2023
With this fix combined with fix to libsixel: saitoha/libsixel#170 browsing on slow machines (e.g., when floating-point calculation is emulated by kernel) gets significantly speed up. Note that if i->cache->a_width (i->cache->a_height) is zero, width (height) should be set to zero. Otherwise, image in screen boundary (i.e., partially displayed) becomes strangely resized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly reduces floating-point calculations when used with,
e.g., w3m.