storage: update to use go-cloud underneath #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhinchley
changed the title
4 tasks
benhinchley
changed the title
|
@dhowden this is now ready for review |
|
Hi! I work on Go Cloud and noticed this integration. How's it going? Any roadblocks? We support Azure now as well as S3 and GCS. |
|
Hey @vangent, I don't remember their being any blockers but this fell off our radar a bit, with other work. I do remember an appengine issue with the vendored deps but I'm unsure if that is still an issue. |
|
OK. Please do let me know if you come back to this and run into any problems, and I will try to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates storage to use go-cloud underneath where possible, without breaking the existing api