Missing version.c

[maltris]

First, thanks for the overhaul of libnss-mysql!

Taking the latest version (47be7bb), tested on Alpine and CentOS 8:

/ # git clone https://github.com/saknopper/libnss-mysql.git
Cloning into 'libnss-mysql'...
remote: Enumerating objects: 2080, done.
remote: Total 2080 (delta 0), reused 0 (delta 0), pack-reused 2080
Receiving objects: 100% (2080/2080), 544.12 KiB | 1.27 MiB/s, done.
Resolving deltas: 100% (1375/1375), done.
/ # cd libnss-mysql/
/libnss-mysql # autoreconf -f -i
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:32: installing 'build-aux/ar-lib'
configure.ac:29: installing 'build-aux/compile'
configure.ac:34: installing 'build-aux/config.guess'
configure.ac:34: installing 'build-aux/config.sub'
configure.ac:25: installing 'build-aux/install-sh'
configure.ac:25: installing 'build-aux/missing'
src/Makefile.am: installing 'build-aux/depcomp'
/libnss-mysql # ./configure
[...]
checking for mysql_config executable... /usr/bin/mysql_config
/usr/bin/mysql_config: unrecognized option: variable=pkgincludedir
grep: /mysql_version.h: No such file or directory
grep: /mysql_version.h: No such file or directory
checking for getsockname in -lsocket... no
[...]
/libnss-mysql # make
make  all-recursive
make[1]: Entering directory '/libnss-mysql'
Making all in src
make[2]: Entering directory '/libnss-mysql/src'
make[2]: *** No rule to make target 'version.c', needed by 'libnss_mysql_la-version.lo'.  Stop.
make[2]: Leaving directory '/libnss-mysql/src'
make[1]: *** [Makefile:419: all-recursive] Error 1
make[1]: Leaving directory '/libnss-mysql'
make: *** [Makefile:351: all] Error 2

There is no version.c file in the tree, but I also found that version.c is explicitly ignored in the gitignore:

./.gitignore:version.c

Creating an empty version.c suffices to proceed with the build:

touch src/version.c

Whats the proper way to proceed here?

[saknopper]

It's been a long time since I've worked on this, thanks for reminding me ;)

Anyway, the fact that version.c is explicitly ignored in the gitignore actually comes from the original cvsignore file. See 5fac93f

So I guess this file is supposed to be automatically generated. If you run the right scripts in the right order... I'll try to have a look at it when I have some more time. But feel free to take a look yourself.

[saknopper]

Turns out I probably got a bit overzealous when cleaning up. It should be fixed now, please reopen if not.

Thanks for reporting!