Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x64 の artifacts に alpha とつける #173

Merged
merged 3 commits into from
Jun 24, 2018
Merged

x64 の artifacts に alpha とつける #173

merged 3 commits into from
Jun 24, 2018

Conversation

m-tmatma
Copy link
Member

#162: x64 の artifacts に alpha とつける

実際に x64 で効果があることを確認するためにはローカルで
upstream の x64 ブランチをマージする必要があります。

@m-tmatma m-tmatma added x64 x64 対応 CI appveyor など CI 関連 【ChangeLog除外】 labels Jun 23, 2018
@m-tmatma m-tmatma added this to the next release milestone Jun 23, 2018
This was referenced Jun 23, 2018
Closed
Closed
@kobake
Copy link
Member

kobake commented Jun 24, 2018

x64 ビルドで、zip 作成までは成功してますが、artifact 名が想定と違っていて
No artifacts found matching 'sakura-x64-Release.zip' path ってなってます。

確認場所

kobake#1
https://ci.appveyor.com/project/kobake/sakura/build/1.0.2

ログ

--
Path = sakura-x64-Release-alpha.zip
Type = zip
Physical Size = 9879607
   Date      Time    Attr         Size   Compressed  Name
------------------- ----- ------------ ------------  ------------------------
2018-06-23 23:43:07 D....            0            0  sakura-x64-Release-alpha
2018-06-23 23:43:07 D....            0            0  sakura-x64-Release-alpha\EXE
2018-06-23 23:43:00 ....A       172517       149253  sakura-x64-Release-alpha\EXE\macro.chm
2018-06-23 23:43:00 ....A        60295        52798  sakura-x64-Release-alpha\EXE\plugin.chm
2018-06-23 23:43:04 ....A      1299141      1275715  sakura-x64-Release-alpha\EXE\sakura.chm
2018-06-23 23:42:55 ....A      2045440       932719  sakura-x64-Release-alpha\EXE\sakura.exe
2018-06-23 23:42:55 ....A     17256448      4219346  sakura-x64-Release-alpha\EXE\sakura.pdb
2018-06-23 23:42:57 ....A       147456        36200  sakura-x64-Release-alpha\EXE\sakura_lang_en_US.dll
2018-06-23 23:42:57 ....A        86016         1517  sakura-x64-Release-alpha\EXE\sakura_lang_en_US.pdb
2018-06-23 23:43:07 D....            0            0  sakura-x64-Release-alpha\Installer
2018-06-23 23:43:07 ....A      3173636      3098159  sakura-x64-Release-alpha\Installer\sakura_install2-3-2-0.exe
2018-06-23 23:43:07 D....            0            0  sakura-x64-Release-alpha\Log
2018-06-23 23:42:59 ....A      1283530       110414  sakura-x64-Release-alpha\Log\msbuild-x64-Release.log
2018-06-23 23:40:13 ....A          207          178  sakura-x64-Release-alpha\warning-alpha.txt
2018-06-23 23:40:09 ....A          615          402  sakura-x64-Release-alpha\warning.txt
------------------- ----- ------------ ------------  ------------------------
2018-06-23 23:43:07           25525301      9876701  11 files, 4 folders
echo appveyor_yml
appveyor_yml
Discovering tests...OK
Collecting artifacts...
No artifacts found matching 'sakura-x64-Release.zip' path
Build success

@berryzplus
Copy link
Contributor

修正要、な空気を感じたのでapproveせず・・・。

No artifacts found matching 'sakura-x64-Release.zip' path

@m-tmatma
Copy link
Member Author

意図せず 5af9743 が入ったので rebase して消します。

@m-tmatma m-tmatma force-pushed the feature/add-alpha-to-x64-artifacts branch from 5af9743 to 6d9e321 Compare June 24, 2018 08:37
@m-tmatma
Copy link
Member Author

6d9e321 で修正しました。

x64 ブランチに対してマージして確認しました。
https://ci.appveyor.com/project/m-tmatma/sakura/build/1.0.194

@kobake
Copy link
Member

kobake commented Jun 24, 2018

こちらでも試してますが大丈夫そうです
https://ci.appveyor.com/project/kobake/sakura/build/1.0.2

kobake
kobake approved these changes Jun 24, 2018
View reviewed changes
Copy link
Member

@kobake kobake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobake kobake merged commit d8a3968 into sakura-editor:master Jun 24, 2018
@m-tmatma m-tmatma deleted the feature/add-alpha-to-x64-artifacts branch June 24, 2018 13:00
@ds14050 ds14050 added x64 x64 対応 CI appveyor など CI 関連 【ChangeLog除外】 labels Sep 18, 2018
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@kobake
Merge pull request sakura-editor#173 from m-tmatma/feature/add-alpha-…
5a5620e 
…to-x64-artifacts

x64 の artifacts に alpha とつける
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobake kobake kobake approved these changes

Assignees
No one assigned
Labels
CI appveyor など CI 関連 【ChangeLog除外】 x64 x64 対応
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@m-tmatma @kobake @berryzplus @ds14050