-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple search providers into Saleor (Typesense) #1452
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
|
1 similar comment
|
@simonfarkas is attempting to deploy a commit to the Saleor Commerce Team on Vercel. A member of the Team first needs to authorize it. |
Hey @simonfarkas Thanks for your contribution. Give us few days to review it 🚀 |
Hey @simonfarkas We are open to accept Typesense integration. However, some time ago we started to split multi-vendor apps into single-vendor ones, due to ease of maintenance and general code complexity. Some time ago we extracted Avatax App from Taxes App and SMTP App from Emails & Messages app. We want Search App to become an Algolia app and we can have Typesense App standalone. I recommend to do it this way:
|
Hello @lkostrowski, Thank you for your review. I have made changes that should meet the requirements of the search application. |
Hey again @simonfarkas We have discussed this PR internally and we decided that we don't want to keep the code that is not currently hosted by Saleor (via Saleor Cloud) in this repository. In the next few days, we will also remove some of the apps we previously maintained (Slack, CRM, Segment, etc) to live in a separate repository. The plan for this repo is to have only apps that are available to be installed in Saleor App Store. I'm sorry to say that but I have to reject this contribution, however if you extract this PR to the repository you own, I will be happy to link it from Saleor docs and promote it as a community resource |
Scope of the PR
This PR adds multiple search providers into Saleor (Algolia, Typesense)
Related issues
#5
Checklist