Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple search providers into Saleor (Typesense) #1452

Closed
wants to merge 18 commits into from

Conversation

simonfarkas
Copy link

Scope of the PR

This PR adds multiple search providers into Saleor (Algolia, Typesense)

Related issues

#5

Checklist

  • You can select which fields to add to providers schema
  • All webhooks work
  • User-friendly configuration
  • Thorough documentation for the Typesense/Algolia integration.
  • Test on large data sets

@simonfarkas simonfarkas requested review from a team as code owners June 21, 2024 18:55
Copy link

changeset-bot bot commented Jun 21, 2024

⚠️ No Changeset found

Latest commit: d7aedc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

vercel bot commented Jun 21, 2024

@simonfarkas is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

@lkostrowski
Copy link
Member

Hey @simonfarkas

Thanks for your contribution. Give us few days to review it 🚀

@lkostrowski lkostrowski self-requested a review June 24, 2024 05:17
@lkostrowski
Copy link
Member

Hey @simonfarkas

We are open to accept Typesense integration. However, some time ago we started to split multi-vendor apps into single-vendor ones, due to ease of maintenance and general code complexity. Some time ago we extracted Avatax App from Taxes App and SMTP App from Emails & Messages app.

We want Search App to become an Algolia app and we can have Typesense App standalone.

I recommend to do it this way:

  1. Copy-paste Search App from your PR to the new Typesense directory
  2. revert changes of the original Search app
  3. Strip Algolia-related code from the new Typesense app

@simonfarkas
Copy link
Author

Hello @lkostrowski,

Thank you for your review. I have made changes that should meet the requirements of the search application.

@lkostrowski
Copy link
Member

Hey again @simonfarkas

We have discussed this PR internally and we decided that we don't want to keep the code that is not currently hosted by Saleor (via Saleor Cloud) in this repository. In the next few days, we will also remove some of the apps we previously maintained (Slack, CRM, Segment, etc) to live in a separate repository.

The plan for this repo is to have only apps that are available to be installed in Saleor App Store.

I'm sorry to say that but I have to reject this contribution, however if you extract this PR to the repository you own, I will be happy to link it from Saleor docs and promote it as a community resource

@lkostrowski lkostrowski closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants